refactor: fix CI, use zod v4, and latest method in mcp
#332
+23
−20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lumirlumir
changed the title
registerToolregisterTool in MCP
This was referenced Nov 27, 2025
Member
Author
|
The CI failure appears to be a regression in I've opened an issue about it in |
lumirlumir
changed the title
registerTool in MCPtool with registerTool in @eslint/mcp
lumirlumir
changed the title
tool with registerTool in @eslint/mcpzod v4, v10_config_lookup_from_file and latest method in mcp
This comment was marked as resolved.
This comment was marked as resolved.
lumirlumir
changed the title
zod v4, v10_config_lookup_from_file and latest method in mcpzod v4, v10 flag and latest method in mcp
lumirlumir
changed the title
zod v4, v10 flag and latest method in mcpzod v4, and latest method in mcp
lumirlumir
commented
Nov 28, 2025
Comment on lines
+26
to
+27
| $schema: "http://json-schema.org/draft-07/schema#", | ||
| additionalProperties: false, |
Member
Author
There was a problem hiding this comment.
If I don't add these two lines, the tests fail, so I've added them.
However, I'm not sure whether this is considered a user-facing change.
lumirlumir
changed the title
zod v4, and latest method in mcpzod v4, and latest method in mcp
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites checklist
What is the purpose of this pull request?
In this PR, I've made several updates, particularly for
@eslint/mcp.Unfortunately, some of the problems have recently arisen in the
rewriterepository, so this PR includes a bit of changes especially for@eslint/mcp.This PR includes the following fixes:
1. Upgrade
@modelcontextprotocol/sdktov1.23.0andzodtov4Two days ago,
@modelcontextprotocol/[email protected]was released.https://github.com/modelcontextprotocol/typescript-sdk/releases/tag/1.23.0
Shortly after that release, our CI began failing with the
TS2589: Type instantiation is excessively deep and possibly infiniteerror.I tried to resolve it myself but couldn't find a suitable solution, so I opened an issue in
@modelcontextprotocol/sdk: modelcontextprotocol/typescript-sdk#1180The issue was traced to the newly introduced Zod v4 support in
@modelcontextprotocol/[email protected].This only affected the
eslint/rewriterepository because the dev-dependencyknipuses Zod v4 internally, while@eslint/mcpdepends on Zod v3, causing a version conflict. The SDK team provided a clear explanation here: modelcontextprotocol/typescript-sdk#1180 (comment)To avoid the conflict, I've bumped Zod to v4. Zod v4 offers v3 compatibility via
zod/v3, so no code changes were necessary.2. Replace deprecated
mcpServer.toolusage withmcpServer.registerToolPer the JSDoc comments in
@modelcontextprotocol/sdk,mcpServer.toolis deprecated, so I've replaced it with the recommendedmcpServer.registerTool.3. The recently released
[email protected]has caused formatting errors:Yesterday,
[email protected]was released and caused formatting errors, particularly in.tsfiles.I've updated it accordingly, which introduced some additional code diffs.
What changes did you make? (Give an overview)
In this PR, I've fixed CI and use
zodv4, and latest method inmcpRelated Issues
Ref: modelcontextprotocol/typescript-sdk#1180 (comment)
Is there anything you'd like reviewers to focus on?
The behavior of MCP has not changed, so I've marked the prefix as
refactor, though I'm not sure about that.