fix: make data property stricter
#327
Conversation
|
It seems that the CI failure is unrelated to this change. |
|
I investigated this and it appears to be a regression in I tried addressing it but couldn't find a clear solution, so I opened an issue in the |
| }, | ||
| "dependencies": { | ||
| "@modelcontextprotocol/sdk": "^1.22.0", | ||
| "@modelcontextprotocol/sdk": "1.22.0", |
There was a problem hiding this comment.
I've pinned the version as a workaround for the CI failure.
(I tried using @ts-expect-error on the exact line where the error occurred, but it didn't work well.)
lumirlumir
force-pushed
the
fix-make-the-data-property-stricter
branch
from
1789094 to
440b8c2
Compare
| "lint-staged": "^16.0.0", | ||
| "mocha": "^11.5.0", | ||
| "prettier": "^3.4.1", | ||
| "prettier": "^3.7.0", |
There was a problem hiding this comment.
Meanwhile, [email protected] was released 30 minutes ago and has also caused CI to fail.
Some additional code diffs were introduced by this change.
|
Marking it as a draft until #332 is merged. |
Prerequisites checklist
What is the purpose of this pull request?
In this PR, I've resolved the issue metioned in #310.
I've updated the
dataproperty to acceptstring | number | boolean | bigint | null | undefinedand added test cases to ensure it works.What changes did you make? (Give an overview)
In this PR, I've resolved the issue metioned in #310.
Related Issues
Closes: #310
Is there anything you'd like reviewers to focus on?
N/A