Skip to content

feat(helm): add service type to helm chart #7302

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 31, 2025
Merged

feat(helm): add service type to helm chart #7302

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
16d538e
add service type to helm chart
saska Oct 22, 2025
d274e94
run helm-generate
saska Oct 23, 2025
ad52db0
run rest of generation
saska Oct 23, 2025
0cb3c20
Merge branch 'main' into add-service-type-to-helm-chart
zirain Oct 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions charts/gateway-helm/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,6 +115,7 @@ helm uninstall eg -n envoy-gateway-system
| podDisruptionBudget.minAvailable | int | `0` | |
| service.annotations | object | `{}` | |
| service.trafficDistribution | string | `""` | |
| service.type | string | `"ClusterIP"` | |
| topologyInjector.annotations | object | `{}` | |
| topologyInjector.enabled | bool | `true` | |

1 change: 1 addition & 0 deletions charts/gateway-helm/templates/envoy-gateway-service.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ metadata:
control-plane: envoy-gateway
{{- include "eg.labels" . | nindent 4 }}
spec:
type: {{ .Values.service.type }}
Copy link
Member

@zirain zirain Oct 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if I understand correctly, this's the service for CP, why do we need to change it?

if the user case is valid, prefer to use empty as default value, render it when user explicitly set it.

Copy link
Contributor Author

@saska saska Oct 24, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kubernetes' default service type is ClusterIP; I preferred to do it this way just so the documentation is explicit that it works the same as k8s would. I.e. the docs are

Key Type Default Description
service.type string "ClusterIP"

instead of

Key Type Default Description
service.type string "" Type of the service. Kubernetes will set this to ClusterIP if not provided.

But either way works for me.

selector:
control-plane: envoy-gateway
{{- include "eg.selectorLabels" . | nindent 4 }}
Expand Down
1 change: 1 addition & 0 deletions charts/gateway-helm/values.tmpl.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,6 +85,7 @@ service:
# If set to PreferClose, the Envoy fleet will prioritize connecting to the Envoy Gateway pods that are topologically closest to them.
trafficDistribution: ""
annotations: {}
type: "ClusterIP"

hpa:
enabled: false
Expand Down
1 change: 1 addition & 0 deletions site/content/en/latest/install/gateway-helm-api.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,6 +79,7 @@ The Helm chart for Envoy Gateway
| podDisruptionBudget.minAvailable | int | `0` | |
| service.annotations | object | `{}` | |
| service.trafficDistribution | string | `""` | |
| service.type | string | `"ClusterIP"` | |
| topologyInjector.annotations | object | `{}` | |
| topologyInjector.enabled | bool | `true` | |

1 change: 1 addition & 0 deletions test/helm/gateway-helm/certgen-annotations.out.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -358,6 +358,7 @@ metadata:
app.kubernetes.io/version: "latest"
app.kubernetes.io/managed-by: Helm
spec:
type: ClusterIP
selector:
control-plane: envoy-gateway
app.kubernetes.io/name: gateway-helm
Expand Down
1 change: 1 addition & 0 deletions test/helm/gateway-helm/certgen-args.out.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -358,6 +358,7 @@ metadata:
app.kubernetes.io/version: "latest"
app.kubernetes.io/managed-by: Helm
spec:
type: ClusterIP
selector:
control-plane: envoy-gateway
app.kubernetes.io/name: gateway-helm
Expand Down
1 change: 1 addition & 0 deletions test/helm/gateway-helm/certgen-labels.out.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -358,6 +358,7 @@ metadata:
app.kubernetes.io/version: "latest"
app.kubernetes.io/managed-by: Helm
spec:
type: ClusterIP
selector:
control-plane: envoy-gateway
app.kubernetes.io/name: gateway-helm
Expand Down
1 change: 1 addition & 0 deletions test/helm/gateway-helm/certjen-custom-scheduling.out.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -358,6 +358,7 @@ metadata:
app.kubernetes.io/version: "latest"
app.kubernetes.io/managed-by: Helm
spec:
type: ClusterIP
selector:
control-plane: envoy-gateway
app.kubernetes.io/name: gateway-helm
Expand Down
1 change: 1 addition & 0 deletions test/helm/gateway-helm/control-plane-with-pdb.out.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -373,6 +373,7 @@ metadata:
app.kubernetes.io/version: "latest"
app.kubernetes.io/managed-by: Helm
spec:
type: ClusterIP
selector:
control-plane: envoy-gateway
app.kubernetes.io/name: gateway-helm
Expand Down
1 change: 1 addition & 0 deletions test/helm/gateway-helm/default-config.out.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -358,6 +358,7 @@ metadata:
app.kubernetes.io/version: "latest"
app.kubernetes.io/managed-by: Helm
spec:
type: ClusterIP
selector:
control-plane: envoy-gateway
app.kubernetes.io/name: gateway-helm
Expand Down
1 change: 1 addition & 0 deletions test/helm/gateway-helm/deployment-annotations.out.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -358,6 +358,7 @@ metadata:
app.kubernetes.io/version: "latest"
app.kubernetes.io/managed-by: Helm
spec:
type: ClusterIP
selector:
control-plane: envoy-gateway
app.kubernetes.io/name: gateway-helm
Expand Down
1 change: 1 addition & 0 deletions test/helm/gateway-helm/deployment-custom-topology.out.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -358,6 +358,7 @@ metadata:
app.kubernetes.io/version: "latest"
app.kubernetes.io/managed-by: Helm
spec:
type: ClusterIP
selector:
control-plane: envoy-gateway
app.kubernetes.io/name: gateway-helm
Expand Down
1 change: 1 addition & 0 deletions test/helm/gateway-helm/deployment-images-config.out.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -358,6 +358,7 @@ metadata:
app.kubernetes.io/version: "latest"
app.kubernetes.io/managed-by: Helm
spec:
type: ClusterIP
selector:
control-plane: envoy-gateway
app.kubernetes.io/name: gateway-helm
Expand Down
1 change: 1 addition & 0 deletions test/helm/gateway-helm/deployment-priorityclass.out.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -358,6 +358,7 @@ metadata:
app.kubernetes.io/version: "latest"
app.kubernetes.io/managed-by: Helm
spec:
type: ClusterIP
selector:
control-plane: envoy-gateway
app.kubernetes.io/name: gateway-helm
Expand Down
1 change: 1 addition & 0 deletions test/helm/gateway-helm/deployment-repo-no-registry.out.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -358,6 +358,7 @@ metadata:
app.kubernetes.io/version: "latest"
app.kubernetes.io/managed-by: Helm
spec:
type: ClusterIP
selector:
control-plane: envoy-gateway
app.kubernetes.io/name: gateway-helm
Expand Down
1 change: 1 addition & 0 deletions test/helm/gateway-helm/deployment-securitycontext.out.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -358,6 +358,7 @@ metadata:
app.kubernetes.io/version: "latest"
app.kubernetes.io/managed-by: Helm
spec:
type: ClusterIP
selector:
control-plane: envoy-gateway
app.kubernetes.io/name: gateway-helm
Expand Down
1 change: 1 addition & 0 deletions test/helm/gateway-helm/envoy-gateway-config.out.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -360,6 +360,7 @@ metadata:
app.kubernetes.io/version: "latest"
app.kubernetes.io/managed-by: Helm
spec:
type: ClusterIP
selector:
control-plane: envoy-gateway
app.kubernetes.io/name: gateway-helm
Expand Down
1 change: 1 addition & 0 deletions test/helm/gateway-helm/envoy-gateway-gateway-namespace-config-watch.out.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -703,6 +703,7 @@ metadata:
app.kubernetes.io/version: "latest"
app.kubernetes.io/managed-by: Helm
spec:
type: ClusterIP
selector:
control-plane: envoy-gateway
app.kubernetes.io/name: gateway-helm
Expand Down
1 change: 1 addition & 0 deletions test/helm/gateway-helm/envoy-gateway-gateway-namespace-config.out.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -444,6 +444,7 @@ metadata:
app.kubernetes.io/version: "latest"
app.kubernetes.io/managed-by: Helm
spec:
type: ClusterIP
selector:
control-plane: envoy-gateway
app.kubernetes.io/name: gateway-helm
Expand Down
1 change: 1 addition & 0 deletions test/helm/gateway-helm/global-images-config.out.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -362,6 +362,7 @@ metadata:
app.kubernetes.io/version: "latest"
app.kubernetes.io/managed-by: Helm
spec:
type: ClusterIP
selector:
control-plane: envoy-gateway
app.kubernetes.io/name: gateway-helm
Expand Down
1 change: 1 addition & 0 deletions test/helm/gateway-helm/global-pullsecrets-override-deployment.out.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -362,6 +362,7 @@ metadata:
app.kubernetes.io/version: "latest"
app.kubernetes.io/managed-by: Helm
spec:
type: ClusterIP
selector:
control-plane: envoy-gateway
app.kubernetes.io/name: gateway-helm
Expand Down
1 change: 1 addition & 0 deletions test/helm/gateway-helm/global-pullsecrets-override-global.out.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -362,6 +362,7 @@ metadata:
app.kubernetes.io/version: "latest"
app.kubernetes.io/managed-by: Helm
spec:
type: ClusterIP
selector:
control-plane: envoy-gateway
app.kubernetes.io/name: gateway-helm
Expand Down
1 change: 1 addition & 0 deletions test/helm/gateway-helm/global-registry-override-deployment.out.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -358,6 +358,7 @@ metadata:
app.kubernetes.io/version: "latest"
app.kubernetes.io/managed-by: Helm
spec:
type: ClusterIP
selector:
control-plane: envoy-gateway
app.kubernetes.io/name: gateway-helm
Expand Down
1 change: 1 addition & 0 deletions test/helm/gateway-helm/global-registry-override-global.out.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -358,6 +358,7 @@ metadata:
app.kubernetes.io/version: "latest"
app.kubernetes.io/managed-by: Helm
spec:
type: ClusterIP
selector:
control-plane: envoy-gateway
app.kubernetes.io/name: gateway-helm
Expand Down
1 change: 1 addition & 0 deletions test/helm/gateway-helm/horizontal-pod-autoscaler.out.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -358,6 +358,7 @@ metadata:
app.kubernetes.io/version: "latest"
app.kubernetes.io/managed-by: Helm
spec:
type: ClusterIP
selector:
control-plane: envoy-gateway
app.kubernetes.io/name: gateway-helm
Expand Down
1 change: 1 addition & 0 deletions test/helm/gateway-helm/service-customization.out.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -360,6 +360,7 @@ metadata:
app.kubernetes.io/version: "latest"
app.kubernetes.io/managed-by: Helm
spec:
type: ClusterIP
selector:
control-plane: envoy-gateway
app.kubernetes.io/name: gateway-helm
Expand Down
1 change: 1 addition & 0 deletions test/helm/gateway-helm/webhook-disabled.out.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -349,6 +349,7 @@ metadata:
app.kubernetes.io/version: "latest"
app.kubernetes.io/managed-by: Helm
spec:
type: ClusterIP
selector:
control-plane: envoy-gateway
app.kubernetes.io/name: gateway-helm
Expand Down
Loading