Skip to content

Conversation

@saska
Copy link
Contributor

@saska saska commented Oct 22, 2025

What type of PR is this?

What this PR does / why we need it:

To set the service type when using the helm chart (to NodePort, LoadBalancer to receive external traffic) unless I'm somehow misunderstanding how the helm chart is supposed to be used.

Which issue(s) this PR fixes:

Fixes #

Release Notes: Yes/No

@saska saska requested a review from a team as a code owner October 22, 2025 12:51
@saska saska force-pushed the add-service-type-to-helm-chart branch 4 times, most recently from 1a3c1b7 to 285c772 Compare October 23, 2025 11:47
saska added 3 commits October 23, 2025 14:48
Signed-off-by: Saska Karsi <[email protected]>
Signed-off-by: Saska Karsi <[email protected]>
@saska saska force-pushed the add-service-type-to-helm-chart branch from 285c772 to ad52db0 Compare October 23, 2025 11:48
@codecov
Copy link

codecov bot commented Oct 23, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 72.05%. Comparing base (21cbec5) to head (0cb3c20).
⚠️ Report is 20 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7302      +/-   ##
==========================================
+ Coverage   72.01%   72.05%   +0.04%     
==========================================
  Files         230      230              
  Lines       33420    33420              
==========================================
+ Hits        24066    24081      +15     
+ Misses       7601     7589      -12     
+ Partials     1753     1750       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

control-plane: envoy-gateway
{{- include "eg.labels" . | nindent 4 }}
spec:
type: {{ .Values.service.type }}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if I understand correctly, this's the service for CP, why do we need to change it?

if the user case is valid, prefer to use empty as default value, render it when user explicitly set it.

Copy link
Contributor Author

@saska saska Oct 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kubernetes' default service type is ClusterIP; I preferred to do it this way just so the documentation is explicit that it works the same as k8s would. I.e. the docs are

Key Type Default Description
service.type string "ClusterIP"

instead of

Key Type Default Description
service.type string "" Type of the service. Kubernetes will set this to ClusterIP if not provided.

But either way works for me.

@zirain zirain enabled auto-merge (squash) October 29, 2025 01:12
@arkodg arkodg disabled auto-merge October 29, 2025 01:21
@arkodg arkodg merged commit 2245030 into envoyproxy:main Oct 31, 2025
35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants