Skip to content

no_garbage_in_glinvalidateframebuffer #4893

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
juj merged 1 commit into from
Jan 28, 2017
Merged

no_garbage_in_glinvalidateframebuffer #4893

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 23 additions & 6 deletions src/library_gl.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,7 @@ var LibraryGL = {
stringCache: {},
#if USE_WEBGL2
stringiCache: {},
tempFixedLengthArray: [],
#endif

packAlignment: 4, // default alignment is 4 bytes
Expand All @@ -75,6 +76,14 @@ var LibraryGL = {
for (var i = 0; i < GL.MINI_TEMP_BUFFER_SIZE; i++) {
GL.miniTempBufferViews[i] = GL.miniTempBuffer.subarray(0, i+1);
}

#if USE_WEBGL2
// For glInvalidateFramebuffer and glInvalidateSubFramebuffer, create a set of short fixed-length arrays to avoid
// having to generate any garbage in those functions.
for (var i = 0; i < 32; i++) {
GL.tempFixedLengthArray.push(new Array(i).fill(0));
}
#endif
},

// Records a GL error condition that occurred, stored until user calls glGetError() to fetch it. As per GLES2 spec, only the first error
Expand Down Expand Up @@ -1674,18 +1683,26 @@ var LibraryGL = {
#if USE_WEBGL2
glInvalidateFramebuffer__sig: 'viii',
glInvalidateFramebuffer: function(target, numAttachments, attachments) {
var list = [];
for (var i = 0; i < numAttachments; i++)
list.push({{{ makeGetValue('attachments', 'i*4', 'i32') }}});
#if GL_ASSERTIONS
assert(numAttachments < GL.tempFixedLengthArray.length, 'Invalid count of numAttachments=' + numAttachments + ' passed to glInvalidateFramebuffer (that many attachment points do not exist in GL)';
#endif
var list = GL.tempFixedLengthArray[numAttachments];
for (var i = 0; i < numAttachments; i++) {
list[i] = {{{ makeGetValue('attachments', 'i*4', 'i32') }}};
}

GLctx['invalidateFramebuffer'](target, list);
},

glInvalidateSubFramebuffer__sig: 'viiiiiii',
glInvalidateSubFramebuffer: function(target, numAttachments, attachments, x, y, width, height) {
var list = [];
for (var i = 0; i < numAttachments; i++)
list.push({{{ makeGetValue('attachments', 'i*4', 'i32') }}});
#if GL_ASSERTIONS
assert(numAttachments < GL.tempFixedLengthArray.length, 'Invalid count of numAttachments=' + numAttachments + ' passed to glInvalidateSubFramebuffer (that many attachment points do not exist in GL)';
#endif
var list = GL.tempFixedLengthArray[numAttachments];
for (var i = 0; i < numAttachments; i++) {
list[i] = {{{ makeGetValue('attachments', 'i*4', 'i32') }}};
}

GLctx['invalidateSubFramebuffer'](target, list, x, y, width, height);
},
Expand Down