no_garbage_in_glinvalidateframebuffer #4893
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kripken
reviewed
Jan 27, 2017
src/library_gl.js
Outdated
| #if USE_WEBGL2 | ||
| // For glInvalidateFramebuffer and glInvalidateSubFramebuffer, create a set of short fixed-length arrays to avoid | ||
| // having to generate any garbage in those functions. | ||
| GL.tempFixedLengthArray = []; |
Member
There was a problem hiding this comment.
better to declare this on the object, tempFixedLengthArray: [], , that way it isn't a new property at this time, better for JS optimizations.
kripken
approved these changes
Jan 27, 2017
Member
kripken
left a comment
kripken
left a comment
There was a problem hiding this comment.
lgtm with those minor comments
src/library_gl.js
Outdated
| for (var i = 0; i < numAttachments; i++) | ||
| list.push({{{ makeGetValue('attachments', 'i*4', 'i32') }}}); | ||
| #if GL_ASSERTIONS | ||
| assert(numAttachments < GL.tempFixedLengthArray.length, 'Invalid count of numAttachments='+numAttachments+' passed to glInvalidateFramebuffer (that many attachment points do not exist in GL)'; |
src/library_gl.js
Outdated
| for (var i = 0; i < numAttachments; i++) | ||
| list.push({{{ makeGetValue('attachments', 'i*4', 'i32') }}}); | ||
| #if GL_ASSERTIONS | ||
| assert(numAttachments < GL.tempFixedLengthArray.length, 'Invalid count of numAttachments='+numAttachments+' passed to glInvalidateSubFramebuffer (that many attachment points do not exist in GL)'; |
…uffer() and glInvalidateSubFramebuffer() functions.
juj
force-pushed
the
no_garbage_in_glinvalidateframebuffer
branch
from
863a074 to
2bc6946
Compare
Collaborator
Author
|
Addressed comments and tested out in real world codebase, which shows we're garbage clean here now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Optimize away temporary garbage created in WebGL 2 glInvalidateFramebuffer() and glInvalidateSubFramebuffer() functions.