Warn about linker inputs when linking is not done #13921
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbc100
force-pushed
the
unused_linker_inputs
branch
2 times, most recently
from
b82d0c8 to
10d7775
Compare
When in compile-only mode warn about unused linker inputs. I took the error string directly from gcc here. ``` $ gcc -c a.o -o out.o gcc: warning: a.o: linker input file unused because linking not done $ echo $? 0 $ stat out.o stat: cannot statx 'out.o': No such file or directory ``` Also, rename `temp_files` to `linker_inputs` which better reflects its purpose. Fixes: #13919
sbc100
force-pushed
the
unused_linker_inputs
branch
from
10d7775 to
b7407a2
Compare
sbc100
added a commit
that referenced
this pull request
Apr 16, 2021
For consistency with #13921 also rename some args and locals in the linking-related functions in building.py. The first argument to these functions are linker arguments that include both files and flags so just calling them args I think is clearer.
sbc100
added a commit
that referenced
this pull request
Apr 16, 2021
For consistency with #13921 also rename some args and locals in the linking-related functions in building.py. The first argument to these functions are linker arguments that include both files and flags so just calling them args I think is clearer.
sbc100
added a commit
that referenced
this pull request
Apr 16, 2021
For consistency with #13921 also rename some args and locals in the linking-related functions in building.py. The first argument to these functions are linker arguments that include both files and flags so just calling them args I think is clearer.
sbc100
added a commit
that referenced
this pull request
Apr 16, 2021
For consistency with #13921 also rename some args and locals in the linking-related functions in building.py. The first argument to these functions are linker arguments that include both files and flags so just calling them args I think is clearer.
Collaborator
|
Nice! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When in compile-only mode warn about unused linker
inputs. I took the error string directly from gcc
here.
Also, rename
temp_filestolinker_inputswhich better reflectsits purpose.
Fixes: #13919