Followup to variable renaming in #13921. NFC #13923
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbc100
force-pushed
the
refactor_link_functions
branch
from
f7865ac to
b2d158a
Compare
tlively
approved these changes
Apr 16, 2021
For consistency with #13921 also rename some args and locals in the linking-related functions in building.py. The first argument to these functions are linker arguments that include both files and flags so just calling them args I think is clearer.
sbc100
force-pushed
the
refactor_link_functions
branch
from
b2d158a to
55f803e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For consistency with #13921 also rename some args and locals in the
linking-related functions in building.py.
The first argument to these functions are linker arguments that include
both files and flags so just calling them args I think is clearer.