Don't do memory operations in pthreads before the runtime is initialized. NFC #12052
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks reasonable but I don't know this code well. @juj? |
sbc100
approved these changes
Aug 28, 2020
juj
reviewed
Oct 23, 2020
| @@ -41,7 +35,8 @@ var LibraryPThread = { | |||
| PThread.allocateUnusedWorker(); | |||
| } | |||
| #endif | |||
|
|
|||
| }, | |||
| initRuntime: function() { | |||
| PThread.mainThreadBlock = {{{ makeStaticAlloc(C_STRUCTS.pthread.__size__) }}}; | |||
There was a problem hiding this comment.
After this change, the function initMainThreadBlock no longer initializes PThread.mainThreadBlock (but instead initRuntime does that). That naming mismatch is awkward, so maybe change name initMainThreadBlock to loadPThreadPool or something like that?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pthreads.initMainThreadBlockis called during "preRun" (before compiled code is ready) andPthreads.initRuntimeis called during "atInit" (when compiled code is ready, just beforeglobal ctors). This moves some code from the former into the latter. Specifically it moves
all allocation and memory operations.
This leaves
initMainThreadBlockto only do pure JS operations for preloading the workers,and everything else to
initRuntime.