Skip to content

Convert some more curly bracket links #792

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Nov 18, 2022
Merged

Convert some more curly bracket links #792

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
03f5116
Convert some more curly bracket links
jenweber Jan 28, 2022
711b0c3
Merge branch 'master' into jw-cm-fix-link
chriskrycho Nov 18, 2022
b3a4531
Merge branch 'master' into jw-cm-fix-link
chriskrycho Nov 18, 2022
79ce524
Merge remote-tracking branch 'origin/master' into jw-cm-fix-link
chriskrycho Nov 18, 2022
4f87046
LinkTo with multiple models needs `@models=`
chriskrycho Nov 18, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 18 additions & 3 deletions app/templates/project-version/classes/class.hbs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,15 @@
{{#if @model.extends}}
<div class="attribute">
<span class="attribute-label">Extends:</span>
<span class="attribute-value">{{#link-to 'project-version.classes.class' @model.extendedClassProjectName @model.projectVersion.compactVersion @model.extendedClassShortName data-test-extends-link=true}}{{@model.extends}}{{/link-to}}</span>
<span class="attribute-value">
<LinkTo
@route="project-version.classes.class"
@models={{array @model.extendedClassProjectName @model.projectVersion.compactVersion @model.extendedClassShortName}}
data-test-extends-link
>
{{@model.extends}}
</LinkTo>
</span>
</div>
{{/if}}
{{#if @model.uses}}
Expand All @@ -18,7 +26,7 @@
<span class="attribute-value">
{{#each @model.usesObjects as |parentClass idx|}}
{{#if (not-eq idx 0)}}<span class="comma">,</span>{{/if}}
{{#link-to 'project-version.classes.class' parentClass.projectId @model.projectVersion.compactVersion parentClass.shortName data-test-uses-link=true}}{{parentClass.name}}{{/link-to}}
<LinkTo @route="project-version.classes.class" @models={{array parentClass.projectId @model.projectVersion.compactVersion parentClass.shortName}} data-test-uses-link>{{parentClass.name}}</LinkTo>
{{/each}}
</span>
</div>
Expand All @@ -34,7 +42,14 @@
{{#if @model.module}}
<div class="attribute">
<span class="attribute-label">Module:</span>
<span class="attribute-value"><LinkTo @route="project-version.modules.module" @models={{array @model.projectVersion.compactVersion @model.module}}>{{@model.module}}</LinkTo></span>
<span class="attribute-value">
<LinkTo
@route="project-version.modules.module"
@models={{array @model.projectVersion.compactVersion @model.module}}
>
{{@model.module}}
</LinkTo>
</span>
</div>
{{/if}}
{{#if @model.since}}
Expand Down