Skip to content

Convert some more curly bracket links #792

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Nov 18, 2022
Merged

Convert some more curly bracket links #792

merged 5 commits into from
Nov 18, 2022

Conversation

jenweber
Copy link
Contributor

No description provided.

@jenweber jenweber requested a review from mansona January 28, 2022 13:58
@chriskrycho
Copy link
Contributor

I believe CI should go green here now that I landed #819.

chriskrycho
chriskrycho approved these changes Nov 18, 2022
View reviewed changes
Copy link
Contributor

@chriskrycho chriskrycho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found and fixed the issue: needed @models= instead of @model= in one of these. CI should go ✅ now!

@chriskrycho chriskrycho merged commit 6d62f83 into master Nov 18, 2022
@chriskrycho chriskrycho deleted the jw-cm-fix-link branch November 18, 2022 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chriskrycho chriskrycho chriskrycho approved these changes

@mansona mansona Awaiting requested review from mansona

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jenweber @chriskrycho