Skip to content

ES|QL: Disable insensitive equals operator #105611

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 19, 2024
Merged

ES|QL: Disable insensitive equals operator #105611

merged 1 commit into from
Feb 19, 2024

Conversation

luigidellaquila
Copy link
Contributor

Disabling case insensitive equals (=~) operator

Resolves #105603

@elasticsearchmachine elasticsearchmachine added the Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) label Feb 19, 2024
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-analytical-engine (Team:Analytics)

astefan
astefan approved these changes Feb 19, 2024
View reviewed changes
Copy link
Contributor

@astefan astefan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@luigidellaquila luigidellaquila merged commit 69b4edf into elastic:main Feb 19, 2024
luigidellaquila added a commit to luigidellaquila/elasticsearch that referenced this pull request Feb 19, 2024
@luigidellaquila
Disable insensitive equals operator (elastic#105611)
fb47e34
@luigidellaquila luigidellaquila mentioned this pull request Feb 19, 2024
Merged
@elasticsearchmachine
Copy link
Collaborator

💚 Backport successful

Status Branch Result
✅ 8.13

@dej611 dej611 mentioned this pull request Feb 19, 2024
Closed
1 task
elasticsearchmachine pushed a commit that referenced this pull request Feb 19, 2024
@luigidellaquila
Disable insensitive equals operator (#105611) (#105613)
e91ab4c
@dej611 dej611 mentioned this pull request Feb 19, 2024
Merged
1 task
dej611 added a commit to elastic/kibana that referenced this pull request Feb 19, 2024
@dej611
[ES|QL] Disable support for case insensitive quality operator (#177171)
c1616fe 
## Summary

Sync with elastic/elasticsearch#105611

Removes the builtin operator from validation and autocomplete.

<img width="595" alt="Screenshot 2024-02-19 at 12 04 37"
src="https://github.com/elastic/kibana/assets/924948/72f0ed8c-5bc3-400d-953b-07a833a7f413">
<img width="540" alt="Screenshot 2024-02-19 at 12 04 25"
src="https://github.com/elastic/kibana/assets/924948/5be38d83-8838-4dbe-8841-1d2d7222dc33">

Tests are currently skipped as the intention to restore it back later
on.

### Checklist

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Feb 19, 2024
@dej611
[ES|QL] Disable support for case insensitive quality operator (elasti…
ed4af52 
…c#177171)

## Summary

Sync with elastic/elasticsearch#105611

Removes the builtin operator from validation and autocomplete.

<img width="595" alt="Screenshot 2024-02-19 at 12 04 37"
src="https://github.com/elastic/kibana/assets/924948/72f0ed8c-5bc3-400d-953b-07a833a7f413">
<img width="540" alt="Screenshot 2024-02-19 at 12 04 25"
src="https://github.com/elastic/kibana/assets/924948/5be38d83-8838-4dbe-8841-1d2d7222dc33">

Tests are currently skipped as the intention to restore it back later
on.

### Checklist

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios

(cherry picked from commit c1616fe)
kibanamachine referenced this pull request in elastic/kibana Feb 19, 2024
@kibanamachine @dej611
[8.13] [ES|QL] Disable support for case insensitive quality operator (#…
a011ab4 
…177171) (#177224)

# Backport

This will backport the following commits from `main` to `8.13`:
- [[ES|QL] Disable support for case insensitive quality operator
(#177171)](#177171)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Marco
Liberati","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-02-19T17:05:28Z","message":"[ES|QL]
Disable support for case insensitive quality operator (#177171)\n\n##
Summary\r\n\r\nSync with
https://github.com/elastic/elasticsearch/pull/105611\r\n\r\nRemoves the
builtin operator from validation and autocomplete.\r\n\r\n<img
width=\"595\" alt=\"Screenshot 2024-02-19 at 12 04
37\"\r\nsrc=\"https://github.com/elastic/kibana/assets/924948/72f0ed8c-5bc3-400d-953b-07a833a7f413\">\r\n<img
width=\"540\" alt=\"Screenshot 2024-02-19 at 12 04
25\"\r\nsrc=\"https://github.com/elastic/kibana/assets/924948/5be38d83-8838-4dbe-8841-1d2d7222dc33\">\r\n\r\nTests
are currently skipped as the intention to restore it back
later\r\non.\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common
scenarios","sha":"c1616fe394518efc5f66f0f4902c1d1c94877de8","branchLabelMapping":{"^v8.14.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Visualizations","release_note:skip","backport:prev-minor","Feature:ES|QL","v8.13.0","v8.14.0"],"title":"[ES|QL]
Disable support for case insensitive quality
operator","number":177171,"url":"https://github.com/elastic/kibana/pull/177171","mergeCommit":{"message":"[ES|QL]
Disable support for case insensitive quality operator (#177171)\n\n##
Summary\r\n\r\nSync with
https://github.com/elastic/elasticsearch/pull/105611\r\n\r\nRemoves the
builtin operator from validation and autocomplete.\r\n\r\n<img
width=\"595\" alt=\"Screenshot 2024-02-19 at 12 04
37\"\r\nsrc=\"https://github.com/elastic/kibana/assets/924948/72f0ed8c-5bc3-400d-953b-07a833a7f413\">\r\n<img
width=\"540\" alt=\"Screenshot 2024-02-19 at 12 04
25\"\r\nsrc=\"https://github.com/elastic/kibana/assets/924948/5be38d83-8838-4dbe-8841-1d2d7222dc33\">\r\n\r\nTests
are currently skipped as the intention to restore it back
later\r\non.\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common
scenarios","sha":"c1616fe394518efc5f66f0f4902c1d1c94877de8"}},"sourceBranch":"main","suggestedTargetBranches":["8.13"],"targetPullRequestStates":[{"branch":"8.13","label":"v8.13.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.14.0","branchLabelMappingKey":"^v8.14.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/177171","number":177171,"mergeCommit":{"message":"[ES|QL]
Disable support for case insensitive quality operator (#177171)\n\n##
Summary\r\n\r\nSync with
https://github.com/elastic/elasticsearch/pull/105611\r\n\r\nRemoves the
builtin operator from validation and autocomplete.\r\n\r\n<img
width=\"595\" alt=\"Screenshot 2024-02-19 at 12 04
37\"\r\nsrc=\"https://github.com/elastic/kibana/assets/924948/72f0ed8c-5bc3-400d-953b-07a833a7f413\">\r\n<img
width=\"540\" alt=\"Screenshot 2024-02-19 at 12 04
25\"\r\nsrc=\"https://github.com/elastic/kibana/assets/924948/5be38d83-8838-4dbe-8841-1d2d7222dc33\">\r\n\r\nTests
are currently skipped as the intention to restore it back
later\r\non.\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common
scenarios","sha":"c1616fe394518efc5f66f0f4902c1d1c94877de8"}}]}]
BACKPORT-->

Co-authored-by: Marco Liberati <[email protected]>
fkanout pushed a commit to fkanout/kibana that referenced this pull request Mar 4, 2024
@dej611 @fkanout
[ES|QL] Disable support for case insensitive quality operator (elasti…
0152c6c 
…c#177171)

## Summary

Sync with elastic/elasticsearch#105611

Removes the builtin operator from validation and autocomplete.

<img width="595" alt="Screenshot 2024-02-19 at 12 04 37"
src="https://github.com/elastic/kibana/assets/924948/72f0ed8c-5bc3-400d-953b-07a833a7f413">
<img width="540" alt="Screenshot 2024-02-19 at 12 04 25"
src="https://github.com/elastic/kibana/assets/924948/5be38d83-8838-4dbe-8841-1d2d7222dc33">

Tests are currently skipped as the intention to restore it back later
on.

### Checklist

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@astefan astefan astefan approved these changes

Assignees

No one assigned

Labels

:Analytics/ES|QL AKA ESQL >non-issue Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) v8.13.0 v8.13.1 v8.14.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

ESQL: Temporary disable =~ case-insensitive operator

3 participants

@luigidellaquila @elasticsearchmachine @astefan