Skip to content

Conversation

leemthompo
Copy link
Contributor

@leemthompo leemthompo commented Feb 1, 2024

Blocked because currently disabled. See #105603.

@leemthompo leemthompo added >docs General docs changes :Analytics/ES|QL AKA ESQL labels Feb 1, 2024
@leemthompo leemthompo self-assigned this Feb 1, 2024
Copy link
Contributor

github-actions bot commented Feb 1, 2024

Documentation preview:


[[esql-binary-operators-equality]]
==== Equality
==== Equality `==`
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚗

@leemthompo leemthompo marked this pull request as ready for review February 1, 2024 18:40
@elasticsearchmachine elasticsearchmachine added Team:Docs Meta label for docs team Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) labels Feb 1, 2024
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-docs (Team:Docs)

@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-analytical-engine (Team:Analytics)

Copy link
Contributor

@luigidellaquila luigidellaquila left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much @leemthompo, I left a comment about a small improvement.

Partially unrelated to this PR, I also noticed that the type tables for binary operators only report integer, integer as valid inputs, while most of the operators accept any type, and =~ does not accept numbers at all.

Screenshot 2024-02-05 alle 13 07 51

I think it's something we'll have to double-check, probably @nik9000 has a quick pointer

@leemthompo
Copy link
Contributor Author

Partially unrelated to this PR, I also noticed that the type tables for binary operators only report integer, integer as valid inputs, while most of the operators accept any type, and =~ does not accept numbers at all.

@luigidellaquila I'll create an issue to look into this separately 👍

@leemthompo
Copy link
Contributor Author

@nik9000 not sure how to proceed here with regards the railroad diagrams

@nik9000
Copy link
Member

nik9000 commented Feb 9, 2024

I think it's something we'll have to double-check, probably @nik9000 has a quick pointer

This is because we don't have tests for those types. @not-napoleon is working on that.

@nik9000
Copy link
Member

nik9000 commented Feb 9, 2024

The reason we don't have a railroad diagram and type table is that those come from building a subclass of AbstractFunctionTestCase for your function. @luigidellaquila, could you do that?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

:Analytics/ES|QL AKA ESQL >docs General docs changes Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) Team:Docs Meta label for docs team v9.0.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ESQL: docs for =~ operator

5 participants