Update to Faraday 1.0 #808
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
picandocodigo
force-pushed
the
update_faraday_7.x
branch
2 times, most recently
from
bbee385 to
293cbfc
Compare
|
That looks promising! As it also cleansup from "stoned" gem :) |
picandocodigo
force-pushed
the
update_faraday_7.x
branch
from
6fbf88e to
1b18df2
Compare
|
@lizdeika thanks for taking a look! 😁 The change from I added a note about Typhoeus, hopefully we'll get a new release soon and the issue will go away 😄 |
NARKOZ
approved these changes
Mar 30, 2020
Migrating to Faraday 1.0 means we check with `adapter` to see which one has been selected. I also changed the order in which the given block is ran. There's a case where one of the adapter libraries could be loaded and an adapter is passed in with the block, but `__auto_detect_adapter` would overwrite this. So the block is now ran last.
picandocodigo
force-pushed
the
update_faraday_7.x
branch
from
1b18df2 to
3d8cff2
Compare
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migration to Faraday 1.0.
adaptermethod to set the adapter, so that's 👍handlersfor loaded adapters in the specs, I changed them to use Faraday'sadapters.Faraday::Errornamespace.Faraday::Errornamespace. This has been fixed on master, but the last release was November 6, 2018. Version 1.4.0 should be ok once it's released.Reference: Upgrading - Faraday 1.0