Version 7.5.0 still has a dependency for older Faraday

[okulik]

From the latest gem's version, elasticsearch-transport.gemspec:

...
s.add_dependency "faraday", '>= 0.14', "< 1"
...

However, the change s.add_dependency "faraday", '~>1' was done a month ago in this commit d3d778a.

[lizdeika]

It was also fixed in master: fd82ac4
This deprecation generates lots of noise :)
Which is the version of elasticsearch-transport to expect the fix?

[picandocodigo]

Hi @okulik, thanks for reporting this. Since Faraday had breaking changes in the latest version, we locked the 7.x branch to the version we were using to be able to release 7.5 without further disruption. But if there's a good case towards 1.0, we could look into upgrading. We try not to introduce breaking changes into minor releases.

@lizdeika Which version of Faraday are you using? It is my understanding version 0.17.3 won't show the deprecation warnings unless FARADAY_DEPRECATE=warn is set. Perhaps the dependency should be locked to 0.17.3?

[lizdeika]

Yes, it's locked now, but it also locks other dependant gems like octokit

[edariedl]

As lizdeika said, it locks dependencies of other gems. We cannot upgrade sentry-raven gem because of the lock on faraday in elasticsearch gems.

Unfortunately major version of elasticsearch gems is locked with elasticsearch version. That would mean that faraday 1.0 will be supported only with release of elasticsearch 8. It is much bigger investment to upgrade whole elasticsearch stack than just the ruby gems. And elasticsearch 8 is not even released yet and release date is not known.

Btw. we use elasticsearch 6 so it would be nice to be able to use faraday 1.0 even with elasticsearch gems version 6.x

[picandocodigo]

We're going to look into using Faraday 1.0 with 6.x and 7.x without major disruption.
Thank you very much for your input!

[picandocodigo]

I've opened a PR for the Faraday migration, take a look if you're interested and let me know if any feedback/comments please:
#808
Thanks!

[picandocodigo]

Version 7.6.0.pre was released on Friday and is using Faraday 1.0. So feel free to check it out and let us know if you find any issues. If everything goes well, we'll be releasing 7.6.0 final this week 👍
Thanks!

[picandocodigo]

Version 7.6.0 has been released with an update to Faraday 1.0. I'm closing this issue but if you have any further problems, please report it on a new issue. Thanks!