-
Notifications
You must be signed in to change notification settings - Fork 728
Make legacy docs asciidoctor compatible #793
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This modifies the legacy client documentation so that it is is compatible with Asciidoctor. With these changes asciidoctor renders the same way as asciidoc, module spacing and a couple of auto-generated ids. I'm willing to ignore the auto-generated anchors because these are legacy docs.
I tried building with
... and they all seemed fine |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/cc @spalger
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but we need to make sure to update the template for the config docs
* Make legacy docs asciidoctor compatible This modifies the legacy client documentation so that it is is compatible with Asciidoctor. With these changes asciidoctor renders the same way as asciidoc, module spacing and a couple of auto-generated ids. I'm willing to ignore the auto-generated anchors because these are legacy docs. * Updated configuration template (cherry picked from commit d699045)
This modifies the legacy client documentation so that it is is
compatible with Asciidoctor. With these changes asciidoctor renders the
same way as asciidoc, module spacing and a couple of auto-generated ids.
I'm willing to ignore the auto-generated anchors because these are
legacy docs.