Updated configuration for js client #701
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
delvedor
added a commit
that referenced
this pull request
Mar 13, 2019
Until #701 gets merged, this is the correct URL to use for build the documentation.
|
I talked with @delvedor about this this morning - we'll merge the old docs into the new repo in a branch called |
|
Note that we might have pages that don't exist in the new version of the docs. I propose at least initially we are ok with that. Once we have tighter control of the redirects on the public web site we can fix the problem quickly. |
|
There are two things blocking this:
|
Because the new docs aren't compatible with AsciiDoc! Which is fine. We're migrating to Asciidoctor. |
Fixed in elastic/elasticsearch-js#793 🎉 |
This handles merging master into the PR branch and it sets up asciidoctor. All of the docs build with this but the link checking fails. You can test this with: ``` ./build_docs --all --target_repo [email protected]:elastic/built-docs.git --open ```
|
@delvedor, I pushed some updates. The docs build now but the link check fails. You can test it locally with: That will take a long time because it has to download a bunch of stuff. Try and do it in a place with a nice internet connection..... Here are the failures I see locally though: The upshot is that we link to You also reference some broken links from your docs. I'm no sure what it is up there but those are usually fairly easy to fix. |
delvedor
added a commit
to elastic/elasticsearch-js
that referenced
this pull request
Mar 28, 2019
Follow up of elastic/docs#701.
delvedor
added a commit
to elastic/elasticsearch-js
that referenced
this pull request
Mar 28, 2019
Follow up of elastic/docs#701.
delvedor
added a commit
to elastic/elasticsearch-js
that referenced
this pull request
Mar 28, 2019
Follow up of elastic/docs#701.
delvedor
added a commit
to elastic/elasticsearch-js
that referenced
this pull request
Mar 28, 2019
Follow up of elastic/docs#701.
|
I opened elastic/elasticsearch-js#799 for what I hope are the last of the broken links. |
|
I need one more PR in the elasticsearch-js client before we can merge this: elastic/elasticsearch-js#801 |
|
That PR is in! We're ready to merge this any time you are ready @delvedor! |
nik9000
approved these changes
Mar 29, 2019
Closed
superdev728
added a commit
to superdev728/elasticsearch-js
that referenced
this pull request
Jun 1, 2023
Follow up of elastic/docs#701.
ZeusMystery
added a commit
to ZeusMystery/elasticsearch
that referenced
this pull request
Dec 20, 2023
Follow up of elastic/docs#701.
ZeusMystery
added a commit
to ZeusMystery/elasticsearch
that referenced
this pull request
Dec 20, 2023
Follow up of elastic/docs#701.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
As you may know, I'm working on the new JavaScript client for Elasticsearch, the code is ready as well as the documentation, the plan is to release the new client with a blog post (https://github.com/elastic/blog/issues/580) at the same time of ES-rc1 (or slightly later).
The current client will be migrated to a new repo to keep all the history, which will be
elasticsearch-js-legacy(I still have to create it).With this pr I'm updating the documentation for the new client, but I don't know if we want to keep the old documentation as well for a while.
I'll keep the pr in draft mode until the new client is ready to go.
/cc @elastic/es-clients @spalger