Skip to content

fix: keep track of indexSlice explicitly in bulk helper response handling loop #1759

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 6, 2023
Merged

fix: keep track of indexSlice explicitly in bulk helper response handling loop #1759

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
56f3d79
fix: keep track of indexSlice separately in bulk helper
karlriis Sep 1, 2022
c95d818
Merge branch 'main' into fix/bulk-helper-delete-action-response-handling
JoshMock Jun 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/helpers.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -823,13 +823,13 @@ export default class Helpers {
}
const retry = []
const { items } = result
let indexSlice = 0
for (let i = 0, len = items.length; i < len; i++) {
const action = items[i]
const operation = Object.keys(action)[0]
// @ts-expect-error
const responseItem = action[operation as keyof T.BulkResponseItemContainer]
assert(responseItem !== undefined, 'The responseItem is undefined, please file a bug report')
const indexSlice = operation !== 'delete' ? i * 2 : i

if (responseItem.status >= 400) {
// 429 is the only staus code where we might want to retry
Expand Down Expand Up @@ -857,6 +857,7 @@ export default class Helpers {
} else {
stats.successful += 1
}
operation === 'delete' ? indexSlice += 1 : indexSlice += 2
}
callback(null, retry)
})
Expand Down