fix: keep track of indexSlice explicitly in bulk helper response handling loop #1759
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
|
@karlriis Thanks for this fix! can you rebase it against latest |
|
@JoshMock Thanks, rebased against latest main now |
|
jenkins test this |
|
buildkite test this |
|
@JoshMock any updates on getting this over the line? |
|
jenkins test this |
|
Tests are failing on Node 14.x for unrelated reasons that I can fix elsewhere. (14.x is also EOL but we'll address that in #1855.) |
JoshMock
added a commit
that referenced
this pull request
Jun 7, 2023
…ling loop (#1759) Co-authored-by: Josh Mock <[email protected]>
JoshMock
added a commit
that referenced
this pull request
Jun 7, 2023
…ling loop (#1759) Co-authored-by: Josh Mock <[email protected]>
JoshMock
added a commit
that referenced
this pull request
Jun 7, 2023
…r response handling loop (#1759) (#1903) Co-authored-by: Karl Riis <[email protected]>
JoshMock
added a commit
that referenced
this pull request
Jun 8, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1751
Fixes the aforementioned issue where a bulk helper call can return wrong information about the erroring operation/document via
onDrop(), or cause a deserialization error when the request contains a delete action combined with any other action.The fix is to keep track of
indexSliceseparately in the response handling loop of thetryBulkmethod, instead of deriving it based on the loop counter. The previous approach didn't account for different types of operations which were handled in previous iterations of the loop.