-
Notifications
You must be signed in to change notification settings - Fork 195
[otel] Implement EDOT diagnostics extension #10052
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This pull request is now in conflicts. Could you fix it? 🙏
|
This pull request does not have a backport label. Could you fix it @VihasMakwana? 🙏
|
d29020f
to
351576b
Compare
9780cfd
to
a754e6a
Compare
a754e6a
to
55f5d4f
Compare
a5095e4
to
e40eb22
Compare
@blakerouse @cmacknz @swiatekm This up for review now! |
|
e7baf30
to
e3dbe0f
Compare
e3dbe0f
to
dd87904
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM overall, had some more comments but they aren't blocking.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good and is ready to merge. I do have one request for an added comment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding the comment. Looks good.
v1.33.0:amd64:basic,slim,complete,service,elastic-otel-collector is timing out in CI to obtain a BK agent, but we don't see this as a blocker. Force merging. |
💛 Build succeeded, but was flaky
Failed CI StepsHistory
|
What does this PR do?
This PR add a new elasticdiagnsotics extension. This new extension will be used in hybrid mode and will perform diagnostics for running otel collector. It will:
runtime/pprof
.extensioncapabilities.ConfigWatcher
interface and stores the latest configuration of the running collector.Checklist
./changelog/fragments
using the changelog toolDisruptive User Impact
None that i can think of. I have to do some final testing on windows to verify this.
Related issues