Skip to content

Conversation

VihasMakwana
Copy link
Contributor

@VihasMakwana VihasMakwana commented Sep 19, 2025

What does this PR do?

This PR add a new elasticdiagnsotics extension. This new extension will be used in hybrid mode and will perform diagnostics for running otel collector. It will:

  • Acts as a registrar and keeps track of common diagnostic hooks.
  • Collects profiles using runtime/pprof.
  • Collects internal telemetry exposed by the OTeL Collector.
  • Implements the extensioncapabilities.ConfigWatcher interface and stores the latest configuration of the running collector.
  • Listens for diagnostic requests and provides diagnostic data.

Checklist

  • I have read and understood the pull request guidelines of this project.
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in ./changelog/fragments using the changelog tool
  • I have added an integration test or an E2E test

Disruptive User Impact

None that i can think of. I have to do some final testing on windows to verify this.

Related issues

Copy link
Contributor

mergify bot commented Sep 19, 2025

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b edot-diagnostics upstream/edot-diagnostics
git merge upstream/main
git push upstream edot-diagnostics

Copy link
Contributor

mergify bot commented Sep 19, 2025

This pull request does not have a backport label. Could you fix it @VihasMakwana? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-./d./d is the label that automatically backports to the 8./d branch. /d is the digit
  • backport-active-all is the label that automatically backports to all active branches.
  • backport-active-8 is the label that automatically backports to all active minor branches for the 8 major.
  • backport-active-9 is the label that automatically backports to all active minor branches for the 9 major.

@VihasMakwana VihasMakwana changed the title [DRAFT] edot diagnostics [EDOT] Implement EDOT diagnostics extension and a new subcommand Sep 22, 2025
@VihasMakwana VihasMakwana changed the title [EDOT] Implement EDOT diagnostics extension and a new subcommand [otel] Implement EDOT diagnostics extension Sep 22, 2025
@VihasMakwana VihasMakwana marked this pull request as ready for review September 22, 2025 16:32
@VihasMakwana VihasMakwana requested a review from a team as a code owner September 22, 2025 16:32
@VihasMakwana
Copy link
Contributor Author

@blakerouse @cmacknz @swiatekm This up for review now!

Copy link

Quality Gate failed Quality Gate failed

Failed conditions
24.1% Coverage on New Code (required ≥ 40%)

See analysis details on SonarQube

swiatekm
swiatekm previously approved these changes Sep 30, 2025
Copy link
Contributor

@swiatekm swiatekm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall, had some more comments but they aren't blocking.

blakerouse
blakerouse previously approved these changes Sep 30, 2025
Copy link
Contributor

@blakerouse blakerouse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good and is ready to merge. I do have one request for an added comment.

Copy link
Contributor

@blakerouse blakerouse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding the comment. Looks good.

@ebeahan
Copy link
Member

ebeahan commented Sep 30, 2025

v1.33.0:amd64:basic,slim,complete,service,elastic-otel-collector is timing out in CI to obtain a BK agent, but we don't see this as a blocker. Force merging.

@ebeahan ebeahan merged commit 47112bd into elastic:main Sep 30, 2025
16 of 21 checks passed
@elasticmachine
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

History

cc @VihasMakwana

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip-changelog Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[beats receivers] Set management.enabled.otel: true for beats receivers

7 participants