fix esm parsing issue in test with node 22.00 by upgrading mocha, and fix "rxjs" package version consistency issue #1418
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR will fix blocked PR #1377 |
danielpeintner
approved these changes
Sep 3, 2025
There was a problem hiding this comment.
LGTM, and thank you for finding the issue 👍
I will try later whether it fixes also the issues we are seeing in #1377
relu91
approved these changes
Sep 3, 2025
erossignon
force-pushed
the
fix/MochaIssue
branch
from
b28d4ee to
2ddd776
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1418 +/- ##
==========================================
- Coverage 77.58% 77.04% -0.54%
==========================================
Files 79 79
Lines 15331 15329 -2
Branches 1445 1439 -6
==========================================
- Hits 11894 11810 -84
- Misses 3414 3496 +82
Partials 23 23 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
ready to merge ! |
erossignon
changed the title
erossignon
force-pushed
the
fix/MochaIssue
branch
from
5cdc083 to
d9e7e2b
Compare
erossignon
requested review from
JKRhb,
egekorkan and
sebastiankb
as code owners
|
Okay let's go with it, even though I am not sure why the inconsistency didn't show up before. |
17 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will fix recurring failing tests in CI/CD with newest revision of nodeJS.
Two changes, in two separate commits
- update mocha to latest version
- fix rxjs": "^5.5.11" consitency issue