-
Notifications
You must be signed in to change notification settings - Fork 88
chore: add Node.js v24 to CI workflow #1377
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
It seems node-mbus seems to cause issues EDIT: opened Apollon77/node-mbus#134 |
We seem to run into a similar issue as mentioned in mochajs/mocha#5317 |
I think the issue has to do with Once I start adding a test with "suite" I get the following message
or messages like
Other test pass. Any proposal? I am wondering whether we should remove
|
The @testdeck/mocha dependency seems no longer providing updates (last update was Dec 2023). We currently use it in some test in the following packages
Shall we make the effort to update those tests, or what is the best way forward? Any other opinions? Maybe there is an easier fix 🤷♂️ |
I created testdeck/testdeck#391 |
No response/feedback in testdeck/testdeck#391. I think we ought to change all tests to remove testdeck dependencies to properly run Node.js 24. |
PR #1418 fixes the CI/CD error that was in mocha. |
# Conflicts: # package-lock.json # packages/binding-mbus/package.json
@relu91 I think the PR is now ready. Please take a look. |
resolves #1373