Drupal 9 compatibility for 3.x #1067
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
'core: 8.x' not needed for 8.8+ 'core_version_requirement' not needed for test modules https://www.drupal.org/node/3070687 Co-authored-by: Damien McKenna <[email protected]>
Co-authored-by: Damien McKenna <[email protected]>
Co-authored-by: Damien McKenna <[email protected]>
…it\Framework\MockObject\MockObject Co-authored-by: Damien McKenna <[email protected]>
Co-authored-by: Damien McKenna <[email protected]>
This was referenced Aug 14, 2020
Closed
Codecov Report
@@ Coverage Diff @@
## 8.x-3.x #1067 +/- ##
==========================================
Coverage 78.71% 78.72%
Complexity 1139 1139
==========================================
Files 192 192
Lines 3026 3027 +1
==========================================
+ Hits 2382 2383 +1
Misses 644 644
Continue to review full report at Codecov.
|
joaogarin
requested review from
fubhy and
pmelab
and removed request for
fubhy
Closed
carolpettirossi
approved these changes
Aug 31, 2020
There was a problem hiding this comment.
I created a patch from #1067 and applied successfully to 3.x-dev. :tallyhappy:
Upgrade status marks as green. However, few warnings that could be fixed (maybe in a separate issue?)
acha5066
approved these changes
Sep 18, 2020
gheydon
suggested changes
Sep 25, 2020
| package: Testing | ||
| dependencies: | ||
| - graphql | ||
| - graphql |
There was a problem hiding this comment.
I know this is small, but we should be using the new format for dependencies, graphql:graphql
Comment on lines
5
to
6
| - block | ||
| - block_content |
| core: 8.x | ||
| core_version_requirement: ^8.8 || ^9 | ||
| dependencies: | ||
| - graphql_breadcrumbs |
| core_version_requirement: ^8.8 || ^9 | ||
| hidden: TRUE | ||
| dependencies: | ||
| - graphql_core |
| core: 8.x | ||
| core_version_requirement: ^8.8 || ^9 | ||
| dependencies: | ||
| - system |
| core_version_requirement: ^8.8 || ^9 | ||
| hidden: TRUE | ||
| dependencies: | ||
| - graphql |
| core_version_requirement: ^8.8 || ^9 | ||
| hidden: TRUE | ||
| dependencies: | ||
| - graphql_plugin_test |
| core_version_requirement: ^8.8 || ^9 | ||
| hidden: TRUE | ||
| dependencies: | ||
| - graphql |
| description: 'Provides type system plugins and derivers on behalf of core modules.' | ||
| package: GraphQL | ||
| core: 8.x | ||
| package: Testing |
There was a problem hiding this comment.
Why? This is not a 'Testing' package - it is a normal submodule that is meant to be installed by users.
Leksat
added a commit
to Leksat/graphql-drupal
that referenced
this pull request
Oct 27, 2020
pmelab
pushed a commit
that referenced
this pull request
Oct 29, 2020
* Update core_version_requirement for Drupal 8.8+ and 9+ 'core: 8.x' not needed for 8.8+ 'core_version_requirement' not needed for test modules https://www.drupal.org/node/3070687 Co-authored-by: Damien McKenna <[email protected]> * Test D9.0 on Travis CI * Replace deprecated drupal_set_message() with messenger->addMessage() Co-authored-by: Damien McKenna <[email protected]> * Replace deprecated file_directory_temp() with getTempDirectory() Co-authored-by: Damien McKenna <[email protected]> * Replace deprecated PHPUnit_Framework_MockObject_MockObject with PHPUnit\Framework\MockObject\MockObject Co-authored-by: Damien McKenna <[email protected]> * Replace deprecated RouteEnhancerInterface with EnhancerInterface Co-authored-by: Damien McKenna <[email protected]> * Remove deprecated PHPUnit_Framework_Error_Warning * Replace 'core: 8.x' with 'core_version_requirement: ^8.8 || ^9' * Replace deprecated entity.manager with entity_type.manager * Must enable the path_alias module in tests * Replace deprecated url() with createFileUrl(FALSE) * Assert menu is an object, rather than assert it is true * chore: adjust things mentioned in #1067 * chore: adjust info.yml files for test modules * chore: trigger travis build * chore: keep composer at version 1 Co-authored-by: Hugo van Kemenade <[email protected]> Co-authored-by: Damien McKenna <[email protected]>
|
Merged in #1102 and released in https://www.drupal.org/project/graphql/releases/8.x-3.1 🎈 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1011.
Based on, replaces and closes #1012 (with thanks to @damienmckenna).
Because the GraphQL v4 module isn't compatible with Drupal 8, contains breaking changes and requires a lot of rewriting, it will help the community to be able migrate to Drupal 9 sooner and by changing fewer things at each step.
Also, v4 is still in beta and therefore not covered by the security advisory policy, so may be not ready for production.
Once migrated to D9, users will be able to perform the v4 upgrade.
The tests pass on Travis CI for Drupal 8.8, 8.9 and 9.0.
Our D8.9 site's own unit tests pass with these changes.