Drupal 9 compatibility for 3.x

[damienmckenna]

Given how much more work needs to be done for a stable release of 4.x, it would be worthwhile resolving Drupal 9 compatibility issues in 3.x and releasing 3.1.

[damienmckenna]

Output from Upgrade Status:

CONTRIBUTED PROJECTS
--------------------------------------------------------------------------------
GraphQL 8.x-3.x-dev
Scanned on Fri, 05/08/2020 - 05:53.

4 errors found. 12 warnings found. Avoid some manual work by using drupal-rector
for fixing issues automatically or Upgrade Rector to generate patches.

modules/contrib/graphql/modules/graphql_core/src/Plugin/GraphQL/Fields/Entity/Fi
elds/Image/ImageDerivative.php:
┌─────────┬──────┬────────────────────────────────────────────────────────────┐
│ STATUS  │ LINE │                          MESSAGE                           │
├─────────┼──────┼────────────────────────────────────────────────────────────┤
│ Fix now │ 88   │ Call to deprecated method url() of class                   │
│         │      │ Drupal\file\Entity\File. Deprecated in drupal:8.0.0 and is │
│         │      │ removed from drupal:9.0.0. Please use toUrl() instead.     │
│         │      │                                                            │
└─────────┴──────┴────────────────────────────────────────────────────────────┘

modules/contrib/graphql/modules/graphql_core/tests/src/Kernel/Entity/EntityRevis
ionsTest.php:
┌──────────┬──────┬──────────────────────────────────────────────────────────────┐
│  STATUS  │ LINE │                           MESSAGE                            │
├──────────┼──────┼──────────────────────────────────────────────────────────────┤
│ Check    │      │ Class                                                        │
│ manually │      │ Drupal\Tests\graphql_core\Kernel\Context\EntityRevisionsTest │
│          │      │ was not found while trying to analyse it - autoloading is    │
│          │      │ probably not configured properly.                            │
│          │      │                                                              │
└──────────┴──────┴──────────────────────────────────────────────────────────────┘

modules/contrib/graphql/modules/graphql_core/tests/src/Kernel/Images/ImageFieldT
est.php:
┌─────────┬──────┬───────────────────────────────────────────────────────────┐
│ STATUS  │ LINE │                          MESSAGE                          │
├─────────┼──────┼───────────────────────────────────────────────────────────┤
│ Fix now │ 73   │ Call to deprecated method url() of class                  │
│         │      │ Drupal\Core\Entity\EntityInterface. Deprecated in         │
│         │      │ drupal:8.0.0 and is removed from drupal:9.0.0. Please use │
│         │      │ toUrl() instead.                                          │
│         │      │                                                           │
└─────────┴──────┴───────────────────────────────────────────────────────────┘

modules/contrib/graphql/src/Form/EntityQueryMapImportForm.php:
┌──────────┬──────┬──────────────────────────────────────────────────────────────┐
│  STATUS  │ LINE │                           MESSAGE                            │
├──────────┼──────┼──────────────────────────────────────────────────────────────┤
│ Fix with │ 76   │ Call to deprecated function drupal_set_message(). Deprecated │
│ rector   │      │ in drupal:8.5.0 and is removed from drupal:9.0.0. Use        │
│          │      │ Drupal\Core\Messenger\MessengerInterface::addMessage()       │
│          │      │ instead.                                                     │
│          │      │                                                              │
└──────────┴──────┴──────────────────────────────────────────────────────────────┘

modules/contrib/graphql/src/Plugin/FieldPluginManager.php:
┌──────────┬──────┬─────────────────────────────────────────────────────────────┐
│  STATUS  │ LINE │                           MESSAGE                           │
├──────────┼──────┼─────────────────────────────────────────────────────────────┤
│ Check    │ 38   │ graphql cache tag might be unclear and does not contain the │
│ manually │      │ cache key in it.                                            │
│          │      │                                                             │
└──────────┴──────┴─────────────────────────────────────────────────────────────┘

modules/contrib/graphql/src/Plugin/MutationPluginManager.php:
┌──────────┬──────┬─────────────────────────────────────────────────────────────┐
│  STATUS  │ LINE │                           MESSAGE                           │
├──────────┼──────┼─────────────────────────────────────────────────────────────┤
│ Check    │ 38   │ graphql cache tag might be unclear and does not contain the │
│ manually │      │ cache key in it.                                            │
│          │      │                                                             │
└──────────┴──────┴─────────────────────────────────────────────────────────────┘

modules/contrib/graphql/src/Plugin/SchemaPluginManager.php:
┌──────────┬──────┬─────────────────────────────────────────────────────────────┐
│  STATUS  │ LINE │                           MESSAGE                           │
├──────────┼──────┼─────────────────────────────────────────────────────────────┤
│ Check    │ 31   │ graphql cache tag might be unclear and does not contain the │
│ manually │      │ cache key in it.                                            │
│          │      │                                                             │
└──────────┴──────┴─────────────────────────────────────────────────────────────┘

modules/contrib/graphql/src/Plugin/SubscriptionPluginManager.php:
┌──────────┬──────┬─────────────────────────────────────────────────────────────┐
│  STATUS  │ LINE │                           MESSAGE                           │
├──────────┼──────┼─────────────────────────────────────────────────────────────┤
│ Check    │ 38   │ graphql cache tag might be unclear and does not contain the │
│ manually │      │ cache key in it.                                            │
│          │      │                                                             │
└──────────┴──────┴─────────────────────────────────────────────────────────────┘

modules/contrib/graphql/src/Routing/QueryRouteEnhancer.php:
┌─────────┬──────┬──────────────────────────────────────────────────────────────┐
│ STATUS  │ LINE │                           MESSAGE                            │
├─────────┼──────┼──────────────────────────────────────────────────────────────┤
│ Fix now │ 13   │ Class Drupal\graphql\Routing\QueryRouteEnhancer implements   │
│         │      │ deprecated interface                                         │
│         │      │ Drupal\Core\Routing\Enhancer\RouteEnhancerInterface.         │
│         │      │ Deprecated in drupal:8.4.0 and is removed from drupal:9.0.0. │
│         │      │ Instead, you should use                                      │
│         │      │ Drupal\Core\Routing\EnhancerInterface. See                   │
│         │      │ https://www.drupal.org/node/2894934 Part of the deprecation  │
│         │      │ means that applies() is now called on runtime instead of     │
│         │      │ compile time.                                                │
│         │      │                                                              │
└─────────┴──────┴──────────────────────────────────────────────────────────────┘

modules/contrib/graphql/tests/src/Kernel/Framework/TestFrameworkTest.php:
┌──────────┬──────┬──────────────────────────────────────────────────────────┐
│  STATUS  │ LINE │                         MESSAGE                          │
├──────────┼──────┼──────────────────────────────────────────────────────────┤
│ Check    │ 38   │ Call to deprecated method assertArraySubset() of class   │
│ manually │      │ PHPUnit\Framework\Assert:                                │
│          │      │ https://github.com/sebastianbergmann/phpunit/issues/3494 │
│          │      │                                                          │
└──────────┴──────┴──────────────────────────────────────────────────────────┘

modules/contrib/graphql/tests/src/Kernel/Framework/UploadMutationTest.php:
┌────────┬──────┬──────────────────────────────────────────────────────────────┐
│ STATUS │ LINE │                           MESSAGE                            │
├────────┼──────┼──────────────────────────────────────────────────────────────┤
│ Fix    │ 21   │ Call to deprecated function file_directory_temp().           │
│ later  │      │ Deprecated in drupal:8.8.0 and is removed from drupal:9.0.0. │
│        │      │ Use                                                          │
│        │      │ \Drupal\Core\File\FileSystemInterface::getTempDirectory()    │
│        │      │ instead.                                                     │
│        │      │                                                              │
└────────┴──────┴──────────────────────────────────────────────────────────────┘

modules/contrib/graphql/tests/src/Traits/MockGraphQLPluginTrait.php (in context
of class Drupal\Tests\graphql\Kernel\GraphQLTestBase):
┌──────────┬──────┬──────────────────────────────────────────────────────────────┐
│  STATUS  │ LINE │                           MESSAGE                            │
├──────────┼──────┼──────────────────────────────────────────────────────────────┤
│ Check    │ 378  │ Return type of method                                        │
│ manually │      │ Drupal\Tests\graphql\Kernel\GraphQLTestBase::mockType() has  │
│          │      │ typehint with deprecated interface                           │
│          │      │ PHPUnit_Framework_MockObject_MockObject: Use                 │
│          │      │ PHPUnit\Framework\MockObject\MockObject instead              │
│          │      │                                                              │
│ Check    │ 469  │ Return type of method                                        │
│ manually │      │ Drupal\Tests\graphql\Kernel\GraphQLTestBase::mockMutation()  │
│          │      │ has typehint with deprecated interface                       │
│          │      │ PHPUnit_Framework_MockObject_MockObject: Use                 │
│          │      │ PHPUnit\Framework\MockObject\MockObject instead              │
│          │      │                                                              │
│ Check    │ 519  │ Return type of method                                        │
│ manually │      │ Drupal\Tests\graphql\Kernel\GraphQLTestBase::mockInterface() │
│          │      │ has typehint with deprecated interface                       │
│          │      │ PHPUnit_Framework_MockObject_MockObject: Use                 │
│          │      │ PHPUnit\Framework\MockObject\MockObject instead              │
│          │      │                                                              │
│ Check    │ 561  │ Return type of method                                        │
│ manually │      │ Drupal\Tests\graphql\Kernel\GraphQLTestBase::mockUnion() has │
│          │      │ typehint with deprecated interface                           │
│          │      │ PHPUnit_Framework_MockObject_MockObject: Use                 │
│          │      │ PHPUnit\Framework\MockObject\MockObject instead              │
│          │      │                                                              │
└──────────┴──────┴──────────────────────────────────────────────────────────────┘

modules/contrib/graphql/graphql.info.yml:
┌──────────┬──────┬─────────────────────────────────────────────────────────────┐
│  STATUS  │ LINE │                           MESSAGE                           │
├──────────┼──────┼─────────────────────────────────────────────────────────────┤
│ Check    │ 0    │ Add <code>core_version_requirement: ^8 || ^9</code> to      │
│ manually │      │ graphql.info.yml to designate that the module is compatible │
│          │      │ with Drupal 9. See https://drupal.org/node/3070687.         │
│          │      │                                                             │
└──────────┴──────┴─────────────────────────────────────────────────────────────┘

[hugovk]

🎈 Drupal 9 is now out!

I agree it would be a good idea to release a D9-compatible 3.x, to allow people to more easily upgrade to D9 first, and then later deal with the breaking changes when 4.x comes out.

[hugovk]

Please see PR #1067 to add D9 compatibility to 3.x.

[hugovk]

Merged in #1102 and released in https://www.drupal.org/project/graphql/releases/8.x-3.1 🎈

(This issue can be closed.)