Skip to content

Add log events in Service Fabric project #580

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 4, 2020
Merged

Add log events in Service Fabric project #580

merged 1 commit into from
Dec 4, 2020

Conversation

@Kahbazi
Copy link
Member

@Kahbazi Kahbazi commented Nov 26, 2020

Fixes #559

@alnikola alnikola self-assigned this Dec 4, 2020
alnikola
alnikola approved these changes Dec 4, 2020
View reviewed changes
Copy link
Contributor

@alnikola alnikola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alnikola alnikola merged commit 0f3e4dd into dotnet:master Dec 4, 2020
@alnikola
Copy link
Contributor

alnikola commented Dec 4, 2020

Thank you!

@Kahbazi Kahbazi deleted the kahbazi/logEvent branch December 4, 2020 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Tratcher Tratcher Awaiting requested review from Tratcher

1 more reviewer

@alnikola alnikola alnikola approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@alnikola alnikola

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[SF] Apply Logging Extension pattern instead of direct ILogger calls

2 participants

@Kahbazi @alnikola