Skip to content
This repository was archived by the owner on Mar 26, 2025. It is now read-only.

Update SPA templates for C#10 #1

Merged
merged 2 commits into from
Jul 16, 2021

Conversation

DamianEdwards
Copy link
Member

  • Implicit usings
  • File-scoped namespace declarations

dotnet/aspnetcore#33947

- Implicit usings
- File-scoped namespace declarations
- Implicit usings
- File-scoped namespace declarations
- Tweaks in Angular template to match
@DamianEdwards DamianEdwards requested a review from dougbu July 15, 2021 21:06
@dougbu
Copy link
Contributor

dougbu commented Jul 15, 2021

#1

Copy link
Contributor

@dougbu dougbu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have a good way to check but am assuming this matches what you changed in dotnet/aspnetcore#34220 then backed out.

If not, ignore my approval and have @pranavkm @davidfowl @JunTaoLuo or other proposed reviewers of dotnet/aspnetcore#34220 chime in here.

@dougbu
Copy link
Contributor

dougbu commented Jul 15, 2021

Lemme know if it's a match and I'll merge if you don't have permissions

@DamianEdwards DamianEdwards requested a review from pranavkm July 15, 2021 22:35
@DamianEdwards DamianEdwards merged commit 65d7a02 into main Jul 16, 2021
@DamianEdwards DamianEdwards deleted the damianedwards/file-scoped-namespaces branch July 16, 2021 01:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants