Update templates to use file scoped namespace declarations #34220
Conversation
DamianEdwards
added
the
blocked
ghost
added
the
area-mvc
| { | ||
| HttpContext.VerifyUserHasAnyAcceptedScope(scopeRequiredByApi); | ||
|
|
||
| using var response = await _downstreamWebApi.CallWebApiForUserAsync("DownstreamApi").ConfigureAwait(false); |
There was a problem hiding this comment.
@davidfowl does this trigger you?
There was a problem hiding this comment.
For the record, I didn't change that, that's simply what was there already 🙃
There was a problem hiding this comment.
What is this................
There was a problem hiding this comment.
Why is it using configure await, I have so many questions.
There was a problem hiding this comment.
This was part of the Identity.Web work: #24024
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
DamianEdwards
force-pushed
the
damianedwards/33947-file-scoped-namespaces
branch
2 times, most recently
from
c9428c1 to
f04c337
Compare
|
So turns out the right branch of Roslyn wasn't flowing into the SDK so we would've been waiting a while for the feature to appear. That's now been fixed so once code flow results in a new SDK being produced and flowed to installer which in turn flows to /aspnetcore (right?) we can finally get this change in. |
DamianEdwards
force-pushed
the
damianedwards/33947-file-scoped-namespaces
branch
from
c713da4 to
03dadf8
Compare
|
@DamianEdwards this is going to conflict w/ the move to https://github.com/dotnet/spa-templates and my current work on the second phase of #32027 (using the new repo as a submodule in this one). Any chance this could wait a day so that your changes to the Spa template could be made in the new repo❔ |
|
@DamianEdwards we're trying to get this in for preview.7, is your change targeting preview.7 too? |
Yes❕ I'll put up the "phase 2" PR shortly after lunch I hope. |
|
@dougbu so should I just undo the changes to the SPA templates given they're moving? |
That'll work for me if it works for you. |
This reverts commit 97ff3da.
DamianEdwards
removed
the
blocked
|
Disabled the warnings that started showing up with the new SDK build (thanks to the new interpolated string builders language feature) on advice from @pranavkm. |
New compiler now makes this appear when using a StringBuilder with string interpolation. I'll log an issue to follow up.
DamianEdwards
force-pushed
the
damianedwards/33947-file-scoped-namespaces
branch
from
b7cdccf to
49dce32
Compare
Depends on dotnet/roslyn#54763 being merged and flowing to SDK before dotnet/aspnetcore can get an SDK with support for this feature in the compiler.
Contributes to #33947 #33948