Use TargetArchitecture and TargetRid properties #47977
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #47950 Architecture -> TargetArchitecture Rid -> TargetRid Unrelated changes: - Remove unused CLIBUILD_SKIP_TESTS property / env var - Consolidate PublishVersionFile and GenerateVersionFile targets
ghost
added
There was a problem hiding this comment.
Pull Request Overview
This PR renames pipeline properties from Architecture to TargetArchitecture and from Rid to TargetRid while removing an unused property and consolidating version file targets.
- Renames property references in SDK job and build pipeline templates.
- Updates command-line parameters for MSBuild to use the new property names.
- Removes references to the unused CLIBUILD_SKIP_TESTS property in the CI pipeline.
Reviewed Changes
Copilot reviewed 3 out of 13 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| eng/pipelines/templates/jobs/sdk-job-matrix.yml | Updated property name from buildArchitecture to targetArchitecture |
| eng/pipelines/templates/jobs/sdk-build.yml | Replaced buildArchitecture and Rid with targetArchitecture and TargetRid in names and command-line arguments |
| .vsts-ci.yml | Removed unused CLIBUILD_SKIP_TESTS property from publishArgument |
Files not reviewed (10)
- Directory.Build.props: Language not supported
- eng/Badge.proj: Language not supported
- eng/Build.props: Language not supported
- src/Layout/Directory.Build.props: Language not supported
- src/Layout/pkg/dotnet-sdk.proj: Language not supported
- src/Layout/redist/targets/GenerateBundledVersions.targets: Language not supported
- src/Layout/redist/targets/GenerateLayout.targets: Language not supported
- src/Layout/redist/targets/RestoreLayout.targets: Language not supported
- src/Layout/redist/tools/tool_fsc.csproj: Language not supported
- src/SourceBuild/content/repo-projects/sdk.proj: Language not supported
|
This one is now ready |
1 task
akoeplinger
approved these changes
Mar 31, 2025
ShreyaLaxminarayan
added a commit
to ShreyaLaxminarayan/dotnet-s390x
that referenced
this pull request
Jun 10, 2025
-Switching to using dotnet/dotnet repository for SDK versions greater than 10.0.0-preview.4 -Updated the source for dependent repository commits: now retrieved from src/manifest.json instead of productCommit-linux-x64.txt. Changes in dotnet-build: - The build parameter /p:MicrosoftNETCoreAppRuntimeVersion in build_aspnetcore has been changed to /p:MicrosoftNETCoreAppRefVersion. Refer to the supporting pr:dotnet/aspnetcore#61860 - The build parameter /p:Architecture in build_sdk has been renamed to /p:TargetArchitecture. Refer to the pr: dotnet/sdk#47977 - The architecture specific property values has been changed in build_sdk Refer to pr: dotnet/sdk#49017
ShreyaLaxminarayan
added a commit
to ShreyaLaxminarayan/dotnet-s390x
that referenced
this pull request
Jun 10, 2025
-Switching to using dotnet/dotnet repository for SDK versions greater than 10.0.0-preview.4 -Updated the source for dependent repository commits: now retrieved from src/manifest.json instead of productCommit-linux-x64.txt. Changes in dotnet-build: - The build parameter /p:MicrosoftNETCoreAppRuntimeVersion in build_aspnetcore has been changed to /p:MicrosoftNETCoreAppRefVersion. Refer to the supporting pr:dotnet/aspnetcore#61860 - The build parameter /p:Architecture in build_sdk has been renamed to /p:TargetArchitecture. Refer to the pr: dotnet/sdk#47977 - The architecture specific property values has been changed in build_sdk Refer to pr: dotnet/sdk#49017 Signed-off-by: shreya <[email protected]>
ShreyaLaxminarayan
added a commit
to ShreyaLaxminarayan/dotnet-s390x
that referenced
this pull request
Jun 24, 2025
-Switching to using dotnet/dotnet repository for SDK versions greater than 10.0.0-preview.4 -Updated the source for dependent repository commits: now retrieved from src/manifest.json instead of productCommit-linux-x64.txt. Changes in dotnet-build: - The build parameter /p:MicrosoftNETCoreAppRuntimeVersion in build_aspnetcore has been changed to /p:MicrosoftNETCoreAppRefVersion. Refer to the supporting pr:dotnet/aspnetcore#61860 - The build parameter /p:Architecture in build_sdk has been renamed to /p:TargetArchitecture. Refer to the pr: dotnet/sdk#47977 - The architecture specific property values has been changed in build_sdk Refer to pr: dotnet/sdk#49017 Signed-off-by: shreya <[email protected]>
giritrivedi
pushed a commit
to IBM/dotnet-s390x
that referenced
this pull request
Jun 24, 2025
-Switching to using dotnet/dotnet repository for SDK versions greater than 10.0.0-preview.4 -Updated the source for dependent repository commits: now retrieved from src/manifest.json instead of productCommit-linux-x64.txt. Changes in dotnet-build: - The build parameter /p:MicrosoftNETCoreAppRuntimeVersion in build_aspnetcore has been changed to /p:MicrosoftNETCoreAppRefVersion. Refer to the supporting pr:dotnet/aspnetcore#61860 - The build parameter /p:Architecture in build_sdk has been renamed to /p:TargetArchitecture. Refer to the pr: dotnet/sdk#47977 - The architecture specific property values has been changed in build_sdk Refer to pr: dotnet/sdk#49017 Signed-off-by: shreya <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #47950
By renaming
ArchitecturetoTargetArchitecture, the RID specific publishing logic works correctly.Architecture -> TargetArchitecture
Rid -> TargetRid
Unrelated changes: