Use Microsoft.NETCore.App.Ref version in place of legacy MicrosoftNETCoreAppPackageVersion #61860
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…CoreAppPackageVersion https://github.com/dotnet/dotnet/blob/main/repo-projects/Directory.Build.props#L247-L251 The reason for this block is that repos tend to use arch specific version properties as proxy version numbers. So aspnetcore will set the runtime pack version based on the MicrosoftNETCoreAppVersion, which it typically sets based on the x64 runtime pack version. But since that's not produced in an x86 build, we jump some through VMR hoops to get this right. The stabilized build exposes a few of these cases where we incorrectly use a few properties, which is quite fixable, but overall this block caught my attention and I think we should remove it. aspnetcore seems to be the biggest user of MicrosoftNETCoreAppVersion, set to the x64 runtime pack version. I was thinking to just changing all the uses to the ref pack version, since the runtime pack and ref pack versions are always aligned. We can then get rid of this block altogether, which would be great
github-actions
bot
added
the
area-infrastructure
wtgodbe
reviewed
May 9, 2025
src/ProjectTemplates/Web.ProjectTemplates/Microsoft.DotNet.Web.ProjectTemplates.csproj
Outdated
Show resolved
Hide resolved
wtgodbe
approved these changes
May 9, 2025
Yep. Not a totally straight find/replace but close. |
ShreyaLaxminarayan
added a commit
to ShreyaLaxminarayan/dotnet-s390x
that referenced
this pull request
Jun 10, 2025
-Switching to using dotnet/dotnet repository for SDK versions greater than 10.0.0-preview.4 -Updated the source for dependent repository commits: now retrieved from src/manifest.json instead of productCommit-linux-x64.txt. Changes in dotnet-build: - The build parameter /p:MicrosoftNETCoreAppRuntimeVersion in build_aspnetcore has been changed to /p:MicrosoftNETCoreAppRefVersion. Refer to the supporting pr:dotnet/aspnetcore#61860 - The build parameter /p:Architecture in build_sdk has been renamed to /p:TargetArchitecture. Refer to the pr: dotnet/sdk#47977 - The architecture specific property values has been changed in build_sdk Refer to pr: dotnet/sdk#49017
ShreyaLaxminarayan
added a commit
to ShreyaLaxminarayan/dotnet-s390x
that referenced
this pull request
Jun 10, 2025
-Switching to using dotnet/dotnet repository for SDK versions greater than 10.0.0-preview.4 -Updated the source for dependent repository commits: now retrieved from src/manifest.json instead of productCommit-linux-x64.txt. Changes in dotnet-build: - The build parameter /p:MicrosoftNETCoreAppRuntimeVersion in build_aspnetcore has been changed to /p:MicrosoftNETCoreAppRefVersion. Refer to the supporting pr:dotnet/aspnetcore#61860 - The build parameter /p:Architecture in build_sdk has been renamed to /p:TargetArchitecture. Refer to the pr: dotnet/sdk#47977 - The architecture specific property values has been changed in build_sdk Refer to pr: dotnet/sdk#49017 Signed-off-by: shreya <[email protected]>
ShreyaLaxminarayan
added a commit
to ShreyaLaxminarayan/dotnet-s390x
that referenced
this pull request
Jun 24, 2025
-Switching to using dotnet/dotnet repository for SDK versions greater than 10.0.0-preview.4 -Updated the source for dependent repository commits: now retrieved from src/manifest.json instead of productCommit-linux-x64.txt. Changes in dotnet-build: - The build parameter /p:MicrosoftNETCoreAppRuntimeVersion in build_aspnetcore has been changed to /p:MicrosoftNETCoreAppRefVersion. Refer to the supporting pr:dotnet/aspnetcore#61860 - The build parameter /p:Architecture in build_sdk has been renamed to /p:TargetArchitecture. Refer to the pr: dotnet/sdk#47977 - The architecture specific property values has been changed in build_sdk Refer to pr: dotnet/sdk#49017 Signed-off-by: shreya <[email protected]>
giritrivedi
pushed a commit
to IBM/dotnet-s390x
that referenced
this pull request
Jun 24, 2025
-Switching to using dotnet/dotnet repository for SDK versions greater than 10.0.0-preview.4 -Updated the source for dependent repository commits: now retrieved from src/manifest.json instead of productCommit-linux-x64.txt. Changes in dotnet-build: - The build parameter /p:MicrosoftNETCoreAppRuntimeVersion in build_aspnetcore has been changed to /p:MicrosoftNETCoreAppRefVersion. Refer to the supporting pr:dotnet/aspnetcore#61860 - The build parameter /p:Architecture in build_sdk has been renamed to /p:TargetArchitecture. Refer to the pr: dotnet/sdk#47977 - The architecture specific property values has been changed in build_sdk Refer to pr: dotnet/sdk#49017 Signed-off-by: shreya <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/dotnet/dotnet/blob/main/repo-projects/Directory.Build.props#L247-L251
The reason for this block is that repos tend to use arch specific version properties as proxy version numbers. So aspnetcore will set the runtime pack version based on the MicrosoftNETCoreAppVersion, which it typically sets based on the x64 runtime pack version. But since that's not produced in an x86 build, we jump some through VMR hoops to get this right. The stabilized build exposes a few of these cases where we incorrectly use a few properties, which is quite fixable, but overall this block caught my attention and I think we should remove it. aspnetcore seems to be the biggest user of MicrosoftNETCoreAppVersion, set to the x64 runtime pack version. I was thinking to just changing all the uses to the ref pack version, since the runtime pack and ref pack versions are always aligned. We can then get rid of this block altogether, which would be great.