Skip to content

[WIP NO MERGE]: Add support for RuntimeFrameworkName to add an additional implicit package ref for ASP.NET Core 2.1 projects #2404

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from
Closed

[WIP NO MERGE]: Add support for RuntimeFrameworkName to add an additional implicit package ref for ASP.NET Core 2.1 projects #2404

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b272955
Implement support for RuntimeFrameworkName in .NET Core 2.1 and up
Jul 17, 2018
9bcb413
Regenerate xlf files
Jul 17, 2018
d0fd901
Revert "Regenerate xlf files"
Jul 17, 2018
ea03aef
Re-regenerate xlf files
Jul 17, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions src/Tasks/Common/Resources/Strings.resx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -397,4 +397,16 @@ The following are names of parameters or literal values and should not be transl
<value>NETSDK1069: This project uses a library that targets .NET Standard 1.5 or higher, and the project targets a version of .NET Framework that doesn't have built-in support for that version of .NET Standard. Visit https://aka.ms/net-standard-known-issues for a set of known issues. Consider retargeting to .NET Framework 4.7.2.</value>
<comment>{StrBegin="NETSDK1069: "}</comment>
</data>
<data name="UnrecognizedRuntimeFrameworkName" xml:space="preserve">
<value>NETSDK1070: This project uses an unsupported value for RuntimeFrameworkName. Currently, only valid values are: Microsoft.NETCore.App, Microsoft.AspNetCore.App, or Microsoft.AspNetCore.All.</value>
<comment>{StrBegin="NETSDK1070: "}</comment>
</data>
<data name="RecommendRuntimeFrameworkNameForAspNetCorePackages" xml:space="preserve">
<value>NETSDK1071: A PackageReference for '{0}' was included in your project. This package can be implicitly defined by the SDK. To resolve this warning, remove this PackageReference and set the RuntimeFrameworkName property to {1}. For more information, see {2}.</value>
<comment>{StrBegin="NETSDK1071: "}
{0} - Package Id (Microsoft.AspNetCore.App or .All)
{1} - Project name
{2} - More info link
</comment>
</data>
</root>
14 changes: 14 additions & 0 deletions src/Tasks/Common/Resources/xlf/Strings.cs.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,15 @@
<target state="needs-review-translation">Chybí metadata {0} o {1} položky {2}.</target>
<note>{StrBegin="NETSDK1008: "}</note>
</trans-unit>
<trans-unit id="RecommendRuntimeFrameworkNameForAspNetCorePackages">
<source>NETSDK1071: A PackageReference for '{0}' was included in your project. This package can be implicitly defined by the SDK. To resolve this warning, remove this PackageReference and set the RuntimeFrameworkName property to {1}. For more information, see {2}.</source>
<target state="new">NETSDK1071: A PackageReference for '{0}' was included in your project. This package can be implicitly defined by the SDK. To resolve this warning, remove this PackageReference and set the RuntimeFrameworkName property to {1}. For more information, see {2}.</target>
<note>{StrBegin="NETSDK1071: "}
{0} - Package Id (Microsoft.AspNetCore.App or .All)
{1} - Project name
{2} - More info link
</note>
</trans-unit>
<trans-unit id="UnrecognizedPreprocessorToken">
<source>NETSDK1009: Unrecognized preprocessor token '{0}' in '{1}'.</source>
<target state="needs-review-translation">Nerozpoznaný token preprocesoru {0} v {1}.</target>
Expand Down Expand Up @@ -112,6 +121,11 @@
<target state="needs-review-translation">Neplatný řetězec verze NuGet: {0}</target>
<note>{StrBegin="NETSDK1018: "}</note>
</trans-unit>
<trans-unit id="UnrecognizedRuntimeFrameworkName">
<source>NETSDK1070: This project uses an unsupported value for RuntimeFrameworkName. Currently, only valid values are: Microsoft.NETCore.App, Microsoft.AspNetCore.App, or Microsoft.AspNetCore.All.</source>
<target state="new">NETSDK1070: This project uses an unsupported value for RuntimeFrameworkName. Currently, only valid values are: Microsoft.NETCore.App, Microsoft.AspNetCore.App, or Microsoft.AspNetCore.All.</target>
<note>{StrBegin="NETSDK1070: "}</note>
</trans-unit>
<trans-unit id="UnsupportedFramework">
<source>NETSDK1019: {0} is an unsupported framework.</source>
<target state="needs-review-translation">{0} není podporovaná platforma.</target>
Expand Down
14 changes: 14 additions & 0 deletions src/Tasks/Common/Resources/xlf/Strings.de.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,15 @@
<target state="needs-review-translation">Die Metadaten "{0}" für das Element "{2}" vom Typ "{1}" sind nicht vorhanden.</target>
<note>{StrBegin="NETSDK1008: "}</note>
</trans-unit>
<trans-unit id="RecommendRuntimeFrameworkNameForAspNetCorePackages">
<source>NETSDK1071: A PackageReference for '{0}' was included in your project. This package can be implicitly defined by the SDK. To resolve this warning, remove this PackageReference and set the RuntimeFrameworkName property to {1}. For more information, see {2}.</source>
<target state="new">NETSDK1071: A PackageReference for '{0}' was included in your project. This package can be implicitly defined by the SDK. To resolve this warning, remove this PackageReference and set the RuntimeFrameworkName property to {1}. For more information, see {2}.</target>
<note>{StrBegin="NETSDK1071: "}
{0} - Package Id (Microsoft.AspNetCore.App or .All)
{1} - Project name
{2} - More info link
</note>
</trans-unit>
<trans-unit id="UnrecognizedPreprocessorToken">
<source>NETSDK1009: Unrecognized preprocessor token '{0}' in '{1}'.</source>
<target state="needs-review-translation">Unbekanntes Präprozessortoken "{0}" in "{1}".</target>
Expand Down Expand Up @@ -112,6 +121,11 @@
<target state="needs-review-translation">Ungültige NuGet-Versionszeichenfolge: {0}.</target>
<note>{StrBegin="NETSDK1018: "}</note>
</trans-unit>
<trans-unit id="UnrecognizedRuntimeFrameworkName">
<source>NETSDK1070: This project uses an unsupported value for RuntimeFrameworkName. Currently, only valid values are: Microsoft.NETCore.App, Microsoft.AspNetCore.App, or Microsoft.AspNetCore.All.</source>
<target state="new">NETSDK1070: This project uses an unsupported value for RuntimeFrameworkName. Currently, only valid values are: Microsoft.NETCore.App, Microsoft.AspNetCore.App, or Microsoft.AspNetCore.All.</target>
<note>{StrBegin="NETSDK1070: "}</note>
</trans-unit>
<trans-unit id="UnsupportedFramework">
<source>NETSDK1019: {0} is an unsupported framework.</source>
<target state="needs-review-translation">{0} ist ein nicht unterstütztes Framework.</target>
Expand Down
14 changes: 14 additions & 0 deletions src/Tasks/Common/Resources/xlf/Strings.es.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,15 @@
<target state="needs-review-translation">Faltan los metadatos de "{0}" en el elemento de "{1}" "{2}".</target>
<note>{StrBegin="NETSDK1008: "}</note>
</trans-unit>
<trans-unit id="RecommendRuntimeFrameworkNameForAspNetCorePackages">
<source>NETSDK1071: A PackageReference for '{0}' was included in your project. This package can be implicitly defined by the SDK. To resolve this warning, remove this PackageReference and set the RuntimeFrameworkName property to {1}. For more information, see {2}.</source>
<target state="new">NETSDK1071: A PackageReference for '{0}' was included in your project. This package can be implicitly defined by the SDK. To resolve this warning, remove this PackageReference and set the RuntimeFrameworkName property to {1}. For more information, see {2}.</target>
<note>{StrBegin="NETSDK1071: "}
{0} - Package Id (Microsoft.AspNetCore.App or .All)
{1} - Project name
{2} - More info link
</note>
</trans-unit>
<trans-unit id="UnrecognizedPreprocessorToken">
<source>NETSDK1009: Unrecognized preprocessor token '{0}' in '{1}'.</source>
<target state="needs-review-translation">Token de preprocesador no reconocido "{0}" en "{1}".</target>
Expand Down Expand Up @@ -112,6 +121,11 @@
<target state="needs-review-translation">Cadena de versión de NuGet no válida: "{0}".</target>
<note>{StrBegin="NETSDK1018: "}</note>
</trans-unit>
<trans-unit id="UnrecognizedRuntimeFrameworkName">
<source>NETSDK1070: This project uses an unsupported value for RuntimeFrameworkName. Currently, only valid values are: Microsoft.NETCore.App, Microsoft.AspNetCore.App, or Microsoft.AspNetCore.All.</source>
<target state="new">NETSDK1070: This project uses an unsupported value for RuntimeFrameworkName. Currently, only valid values are: Microsoft.NETCore.App, Microsoft.AspNetCore.App, or Microsoft.AspNetCore.All.</target>
<note>{StrBegin="NETSDK1070: "}</note>
</trans-unit>
<trans-unit id="UnsupportedFramework">
<source>NETSDK1019: {0} is an unsupported framework.</source>
<target state="needs-review-translation">{0} es una plataforma no compatible.</target>
Expand Down
14 changes: 14 additions & 0 deletions src/Tasks/Common/Resources/xlf/Strings.fr.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,15 @@
<target state="needs-review-translation">Métadonnées '{0}' manquantes sur l'élément '{1}' '{2}'.</target>
<note>{StrBegin="NETSDK1008: "}</note>
</trans-unit>
<trans-unit id="RecommendRuntimeFrameworkNameForAspNetCorePackages">
<source>NETSDK1071: A PackageReference for '{0}' was included in your project. This package can be implicitly defined by the SDK. To resolve this warning, remove this PackageReference and set the RuntimeFrameworkName property to {1}. For more information, see {2}.</source>
<target state="new">NETSDK1071: A PackageReference for '{0}' was included in your project. This package can be implicitly defined by the SDK. To resolve this warning, remove this PackageReference and set the RuntimeFrameworkName property to {1}. For more information, see {2}.</target>
<note>{StrBegin="NETSDK1071: "}
{0} - Package Id (Microsoft.AspNetCore.App or .All)
{1} - Project name
{2} - More info link
</note>
</trans-unit>
<trans-unit id="UnrecognizedPreprocessorToken">
<source>NETSDK1009: Unrecognized preprocessor token '{0}' in '{1}'.</source>
<target state="needs-review-translation">Jeton de préprocesseur '{0}' non reconnu dans '{1}'.</target>
Expand Down Expand Up @@ -112,6 +121,11 @@
<target state="needs-review-translation">Chaîne de version NuGet non valide : '{0}'.</target>
<note>{StrBegin="NETSDK1018: "}</note>
</trans-unit>
<trans-unit id="UnrecognizedRuntimeFrameworkName">
<source>NETSDK1070: This project uses an unsupported value for RuntimeFrameworkName. Currently, only valid values are: Microsoft.NETCore.App, Microsoft.AspNetCore.App, or Microsoft.AspNetCore.All.</source>
<target state="new">NETSDK1070: This project uses an unsupported value for RuntimeFrameworkName. Currently, only valid values are: Microsoft.NETCore.App, Microsoft.AspNetCore.App, or Microsoft.AspNetCore.All.</target>
<note>{StrBegin="NETSDK1070: "}</note>
</trans-unit>
<trans-unit id="UnsupportedFramework">
<source>NETSDK1019: {0} is an unsupported framework.</source>
<target state="needs-review-translation">{0} est un framework non pris en charge.</target>
Expand Down
14 changes: 14 additions & 0 deletions src/Tasks/Common/Resources/xlf/Strings.it.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,15 @@
<target state="needs-review-translation">Mancano i metadati di '{0}' sull'elemento '{2}' di '{1}'.</target>
<note>{StrBegin="NETSDK1008: "}</note>
</trans-unit>
<trans-unit id="RecommendRuntimeFrameworkNameForAspNetCorePackages">
<source>NETSDK1071: A PackageReference for '{0}' was included in your project. This package can be implicitly defined by the SDK. To resolve this warning, remove this PackageReference and set the RuntimeFrameworkName property to {1}. For more information, see {2}.</source>
<target state="new">NETSDK1071: A PackageReference for '{0}' was included in your project. This package can be implicitly defined by the SDK. To resolve this warning, remove this PackageReference and set the RuntimeFrameworkName property to {1}. For more information, see {2}.</target>
<note>{StrBegin="NETSDK1071: "}
{0} - Package Id (Microsoft.AspNetCore.App or .All)
{1} - Project name
{2} - More info link
</note>
</trans-unit>
<trans-unit id="UnrecognizedPreprocessorToken">
<source>NETSDK1009: Unrecognized preprocessor token '{0}' in '{1}'.</source>
<target state="needs-review-translation">Token di preprocessore '{0}' non riconosciuto in '{1}'.</target>
Expand Down Expand Up @@ -112,6 +121,11 @@
<target state="needs-review-translation">La stringa di versione '{0}' di NuGet non è valida.</target>
<note>{StrBegin="NETSDK1018: "}</note>
</trans-unit>
<trans-unit id="UnrecognizedRuntimeFrameworkName">
<source>NETSDK1070: This project uses an unsupported value for RuntimeFrameworkName. Currently, only valid values are: Microsoft.NETCore.App, Microsoft.AspNetCore.App, or Microsoft.AspNetCore.All.</source>
<target state="new">NETSDK1070: This project uses an unsupported value for RuntimeFrameworkName. Currently, only valid values are: Microsoft.NETCore.App, Microsoft.AspNetCore.App, or Microsoft.AspNetCore.All.</target>
<note>{StrBegin="NETSDK1070: "}</note>
</trans-unit>
<trans-unit id="UnsupportedFramework">
<source>NETSDK1019: {0} is an unsupported framework.</source>
<target state="needs-review-translation">{0} è un framework non supportato.</target>
Expand Down
14 changes: 14 additions & 0 deletions src/Tasks/Common/Resources/xlf/Strings.ja.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,15 @@
<target state="needs-review-translation">'{1}' 項目 '{2}' の '{0}' メタデータがありません。</target>
<note>{StrBegin="NETSDK1008: "}</note>
</trans-unit>
<trans-unit id="RecommendRuntimeFrameworkNameForAspNetCorePackages">
<source>NETSDK1071: A PackageReference for '{0}' was included in your project. This package can be implicitly defined by the SDK. To resolve this warning, remove this PackageReference and set the RuntimeFrameworkName property to {1}. For more information, see {2}.</source>
<target state="new">NETSDK1071: A PackageReference for '{0}' was included in your project. This package can be implicitly defined by the SDK. To resolve this warning, remove this PackageReference and set the RuntimeFrameworkName property to {1}. For more information, see {2}.</target>
<note>{StrBegin="NETSDK1071: "}
{0} - Package Id (Microsoft.AspNetCore.App or .All)
{1} - Project name
{2} - More info link
</note>
</trans-unit>
<trans-unit id="UnrecognizedPreprocessorToken">
<source>NETSDK1009: Unrecognized preprocessor token '{0}' in '{1}'.</source>
<target state="needs-review-translation">認識されないプリプロセッサ トークン '{0}' が '{1}' に存在します。</target>
Expand Down Expand Up @@ -112,6 +121,11 @@
<target state="needs-review-translation">無効な NuGet バージョン文字列: '{0}'。</target>
<note>{StrBegin="NETSDK1018: "}</note>
</trans-unit>
<trans-unit id="UnrecognizedRuntimeFrameworkName">
<source>NETSDK1070: This project uses an unsupported value for RuntimeFrameworkName. Currently, only valid values are: Microsoft.NETCore.App, Microsoft.AspNetCore.App, or Microsoft.AspNetCore.All.</source>
<target state="new">NETSDK1070: This project uses an unsupported value for RuntimeFrameworkName. Currently, only valid values are: Microsoft.NETCore.App, Microsoft.AspNetCore.App, or Microsoft.AspNetCore.All.</target>
<note>{StrBegin="NETSDK1070: "}</note>
</trans-unit>
<trans-unit id="UnsupportedFramework">
<source>NETSDK1019: {0} is an unsupported framework.</source>
<target state="needs-review-translation">{0} は、サポートされていないフレームワークです。</target>
Expand Down
14 changes: 14 additions & 0 deletions src/Tasks/Common/Resources/xlf/Strings.ko.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,15 @@
<target state="needs-review-translation">'{1}' 항목 '{2}'에 '{0}' 메타데이터가 없습니다.</target>
<note>{StrBegin="NETSDK1008: "}</note>
</trans-unit>
<trans-unit id="RecommendRuntimeFrameworkNameForAspNetCorePackages">
<source>NETSDK1071: A PackageReference for '{0}' was included in your project. This package can be implicitly defined by the SDK. To resolve this warning, remove this PackageReference and set the RuntimeFrameworkName property to {1}. For more information, see {2}.</source>
<target state="new">NETSDK1071: A PackageReference for '{0}' was included in your project. This package can be implicitly defined by the SDK. To resolve this warning, remove this PackageReference and set the RuntimeFrameworkName property to {1}. For more information, see {2}.</target>
<note>{StrBegin="NETSDK1071: "}
{0} - Package Id (Microsoft.AspNetCore.App or .All)
{1} - Project name
{2} - More info link
</note>
</trans-unit>
<trans-unit id="UnrecognizedPreprocessorToken">
<source>NETSDK1009: Unrecognized preprocessor token '{0}' in '{1}'.</source>
<target state="needs-review-translation">'{1}'에서 전처리기 토큰 '{0}'을(를) 인식할 수 없습니다.</target>
Expand Down Expand Up @@ -112,6 +121,11 @@
<target state="needs-review-translation">NuGet 버전 문자열 '{0}'이(가) 잘못되었습니다.</target>
<note>{StrBegin="NETSDK1018: "}</note>
</trans-unit>
<trans-unit id="UnrecognizedRuntimeFrameworkName">
<source>NETSDK1070: This project uses an unsupported value for RuntimeFrameworkName. Currently, only valid values are: Microsoft.NETCore.App, Microsoft.AspNetCore.App, or Microsoft.AspNetCore.All.</source>
<target state="new">NETSDK1070: This project uses an unsupported value for RuntimeFrameworkName. Currently, only valid values are: Microsoft.NETCore.App, Microsoft.AspNetCore.App, or Microsoft.AspNetCore.All.</target>
<note>{StrBegin="NETSDK1070: "}</note>
</trans-unit>
<trans-unit id="UnsupportedFramework">
<source>NETSDK1019: {0} is an unsupported framework.</source>
<target state="needs-review-translation">{0}은(는) 지원되지 않는 프레임워크입니다.</target>
Expand Down
14 changes: 14 additions & 0 deletions src/Tasks/Common/Resources/xlf/Strings.pl.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,15 @@
<target state="needs-review-translation">Brak metadanych „{0}” w elemencie „{1}” „{2}”.</target>
<note>{StrBegin="NETSDK1008: "}</note>
</trans-unit>
<trans-unit id="RecommendRuntimeFrameworkNameForAspNetCorePackages">
<source>NETSDK1071: A PackageReference for '{0}' was included in your project. This package can be implicitly defined by the SDK. To resolve this warning, remove this PackageReference and set the RuntimeFrameworkName property to {1}. For more information, see {2}.</source>
<target state="new">NETSDK1071: A PackageReference for '{0}' was included in your project. This package can be implicitly defined by the SDK. To resolve this warning, remove this PackageReference and set the RuntimeFrameworkName property to {1}. For more information, see {2}.</target>
<note>{StrBegin="NETSDK1071: "}
{0} - Package Id (Microsoft.AspNetCore.App or .All)
{1} - Project name
{2} - More info link
</note>
</trans-unit>
<trans-unit id="UnrecognizedPreprocessorToken">
<source>NETSDK1009: Unrecognized preprocessor token '{0}' in '{1}'.</source>
<target state="needs-review-translation">Nierozpoznany token preprocesora „{0}” w elemencie „{1}”.</target>
Expand Down Expand Up @@ -112,6 +121,11 @@
<target state="needs-review-translation">Nieprawidłowy ciąg wersji NuGet: „{0}”.</target>
<note>{StrBegin="NETSDK1018: "}</note>
</trans-unit>
<trans-unit id="UnrecognizedRuntimeFrameworkName">
<source>NETSDK1070: This project uses an unsupported value for RuntimeFrameworkName. Currently, only valid values are: Microsoft.NETCore.App, Microsoft.AspNetCore.App, or Microsoft.AspNetCore.All.</source>
<target state="new">NETSDK1070: This project uses an unsupported value for RuntimeFrameworkName. Currently, only valid values are: Microsoft.NETCore.App, Microsoft.AspNetCore.App, or Microsoft.AspNetCore.All.</target>
<note>{StrBegin="NETSDK1070: "}</note>
</trans-unit>
<trans-unit id="UnsupportedFramework">
<source>NETSDK1019: {0} is an unsupported framework.</source>
<target state="needs-review-translation">{0} to nieobsługiwana platforma.</target>
Expand Down
Loading