[WIP NO MERGE]: Add support for RuntimeFrameworkName to add an additional implicit package ref for ASP.NET Core 2.1 projects

[natemcmaster]

Part of dotnet/aspnetcore#3307

An alternative to #2394, which doesn't require changes to runtime packages and keeps the baseline for ASP.NET Core at 2.1.1 (which is the baseline in the 2.1.301 SDK).

Changes:

• Introduce a new property, RuntimeFrameworkName, which defines an additional implicit package reference added when targeting .NET Core. The default platform package, Microsoft.NETCore.App, is still always referenced
• Add information about the default implicit version to use for ASP.NET Core metapackages to use (when selected as the runtime framework)
• Fail the build if an unrecognized value for RuntimeFrameworkName is specified in a .NET Core project.
• Add a warning when the project contains an explicit PackageReference to AspNetCore.All/App

[natemcmaster]

xlf regeneration appeared to mess up Strings.ru.xlf. Does this require manual fixup for some reason?

[nguerrera]

No manual fixup of xlf should be required. That would be an xliff-tasks bug. I'll investigate.

[nguerrera]

Not sure what happened to strings.ru.xlf. I've never seen that before. It's behaving as though it didn't think the file already had content.

I'm not sure how to repro it either. I have a feeling the following would solve it, but then we'd lose our repro :(

1. Revert 9bcb413
2. git clean -fdx (careful!)
3. build

Given a bunch of things under time pressure in parallel today, I think we should try that. Can you back up your bin/obj directory somewhere first, so that I can take a look for any clues left behind by the bad update.

[natemcmaster]

Ok, I think the xlf files are correct now.

When I ran build.cmd the first time while preparing this PR, UpdateXlf failed. I wondered if this might be related to corruption of Strings.ru.xlf, but the error said the issue was with Strings.es.xlf.

C:\Users\namc\.nuget\packages\xlifftasks\0.2.0-beta-62730-03\build\XliffTasks.targets(91,5): error MSB4018: The "UpdateXlf" task failed unexpectedly. [C:\dev\dotnet\sdk\src\Tests\Microsoft.NET.Publish.Tests\Microsoft.NET.Publish.Tests.csproj]
C:\Users\namc\.nuget\packages\xlifftasks\0.2.0-beta-62730-03\build\XliffTasks.targets(91,5): error MSB4018: System.IO.IOException: The process cannot access the file 'C:\dev\dotnet\sdk\src\Tasks\Common\Resources\xlf\Strings.es.xlf' because it is being used by another process. [C:\dev\dotnet\sdk\src\Tests\Microsoft.NET.Publish.Tests\Microsoft.NET.Publish.Tests.csproj]
C:\Users\namc\.nuget\packages\xlifftasks\0.2.0-beta-62730-03\build\XliffTasks.targets(91,5): error MSB4018:    at System.IO.FileStream.ValidateFileHandle(SafeFileHandle fileHandle) [C:\dev\dotnet\sdk\src\Tests\Microsoft.NET.Publish.Tests\Microsoft.NET.Publish.Tests.csproj]
C:\Users\namc\.nuget\packages\xlifftasks\0.2.0-beta-62730-03\build\XliffTasks.targets(91,5): error MSB4018:    at System.IO.FileStream.CreateFileOpenHandle(FileMode mode, FileShare share, FileOptions options) [C:\dev\dotnet\sdk\src\Tests\Microsoft.NET.Publish.Tests\Microsoft.NET.Publish.Tests.csproj]
C:\Users\namc\.nuget\packages\xlifftasks\0.2.0-beta-62730-03\build\XliffTasks.targets(91,5): error MSB4018:    at System.IO.FileStream..ctor(String path, FileMode mode, FileAccess access, FileShare share, Int32 bufferSize, FileOptions options) [C:\dev\dotnet\sdk\src\Tests\Microsoft.NET.Publish.Tests\Microsoft.NET.Publish.Tests.csproj]
C:\Users\namc\.nuget\packages\xlifftasks\0.2.0-beta-62730-03\build\XliffTasks.targets(91,5): error MSB4018:    at XliffTasks.Model.Document.Load(String path) in /_/src/XliffTasks/Model/Document.cs:line 31 [C:\dev\dotnet\sdk\src\Tests\Microsoft.NET.Publish.Tests\Microsoft.NET.Publish.Tests.csproj]
C:\Users\namc\.nuget\packages\xlifftasks\0.2.0-beta-62730-03\build\XliffTasks.targets(91,5): error MSB4018:    at XliffTasks.Tasks.XlfTask.LoadXlfDocument(String path, String language, Boolean createIfNonExistent) in /_/src/XliffTasks/Tasks/XlfTask.cs:line 67 [C:\dev\dotnet\sdk\src\Tests\Microsoft.NET.Publish.Tests\Microsoft.NET.Publish.Tests.csproj]
C:\Users\namc\.nuget\packages\xlifftasks\0.2.0-beta-62730-03\build\XliffTasks.targets(91,5): error MSB4018:    at XliffTasks.Tasks.UpdateXlf.ExecuteCore() in /_/src/XliffTasks/Tasks/UpdateXlf.cs:line 37 [C:\dev\dotnet\sdk\src\Tests\Microsoft.NET.Publish.Tests\Microsoft.NET.Publish.Tests.csproj]
C:\Users\namc\.nuget\packages\xlifftasks\0.2.0-beta-62730-03\build\XliffTasks.targets(91,5): error MSB4018:    at XliffTasks.Tasks.XlfTask.Execute() in /_/src/XliffTasks/Tasks/XlfTask.cs:line 19 [C:\dev\dotnet\sdk\src\Tests\Microsoft.NET.Publish.Tests\Microsoft.NET.Publish.Tests.csproj]
C:\Users\namc\.nuget\packages\xlifftasks\0.2.0-beta-62730-03\build\XliffTasks.targets(91,5): error MSB4018:    at Microsoft.Build.BackEnd.TaskExecutionHost.Microsoft.Build.BackEnd.ITaskExecutionHost.Execute() [C:\dev\dotnet\sdk\src\Tests\Microsoft.NET.Publish.Tests\Microsoft.NET.Publish.Tests.csproj]
C:\Users\namc\.nuget\packages\xlifftasks\0.2.0-beta-62730-03\build\XliffTasks.targets(91,5): error MSB4018:    at Microsoft.Build.BackEnd.TaskBuilder.ExecuteInstantiatedTask(ITaskExecutionHost taskExecutionHost, TaskLoggingContext taskLoggingContext, TaskHost taskHost, ItemBucket bucket, TaskExecutionMode howToExecuteTask) [C:\dev\dotnet\sdk\src\Tests\Microsoft.NET.Publish.Tests\Microsoft.NET.Publish.Tests.csproj]

[nguerrera]

I think that access issue is a bug that was fixed in xliff-tasks, I'll check if we're not on latest

[nguerrera]

I understood the rationale for why we can have just one property is that we will align the versions of these shared frameworks. It makes me wonder why we have separate logic for setting the version of each of them here.

[nguerrera]

Presumably because when we have the core shared framework, the baseline is still 2.1.0, but we've already set the precedent of a different baseline of 2.1.1 for ASP.NET?

[natemcmaster]

Yup, that's why. I only added the separate properties because aspnetcore's baseline is 2.1.1 (for now.)

[natemcmaster]

Per conversation in person, we are no longer pursuing this fix in 2.1.4xx.