Skip to content

JIT: don't ask for all write barrer helpers for AOT #97677

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 30, 2024
Merged

JIT: don't ask for all write barrer helpers for AOT #97677

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4db68df
JIT: don't ask for all write barrer helpers for AOT
AndyAyersMS Jan 29, 2024
2b3345e
add back the initial semicolon to the metrics line
AndyAyersMS Jan 30, 2024
1bdd225
Update src/coreclr/jit/codegencommon.cpp
jkotas Jan 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions src/coreclr/jit/codegencommon.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1701,7 +1701,9 @@ void CodeGen::genGenerateCode(void** codePtr, uint32_t* nativeSizeOfCode)
DoPhase(this, PHASE_EMIT_GCEH, &CodeGen::genEmitUnwindDebugGCandEH);

#ifdef DEBUG
if (genWriteBarrierUsed && JitConfig.EnableExtraSuperPmiQueries())
// For R2R/NAOT not all these helpers are implemented. So don't ask for them.
//
if (genWriteBarrierUsed && JitConfig.EnableExtraSuperPmiQueries() && !compiler->opts.IsReadyToRun())
{
void* ignored;
for (int i = CORINFO_HELP_ASSIGN_REF; i <= CORINFO_HELP_ASSIGN_STRUCT; i++)
Expand Down Expand Up @@ -2036,7 +2038,7 @@ void CodeGen::genEmitMachineCode()
printf("\n");
}

printf("Total bytes of code %d, prolog size %d, PerfScore %.2f, instruction count %d, allocated bytes for "
printf("; Total bytes of code %d, prolog size %d, PerfScore %.2f, instruction count %d, allocated bytes for "
"code %d",
codeSize, prologSize, compiler->info.compPerfScore, instrCount,
GetEmitter()->emitTotalHotCodeSize + GetEmitter()->emitTotalColdCodeSize);
Expand Down