JIT: don't ask for all write barrer helpers for AOT #97677
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes an issue introduced by dotnet#97535. AOT hosts don't support all the possible write barriers and blow things up if the JIT asks for ones they don't support.
ghost
added
the
area-CodeGen-coreclr
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch Issue DetailsFixes an issue introduced by #97535. AOT hosts don't support all the possible write barriers and blow things up if the JIT asks for ones they don't support.
|
|
@jakobbotsch PTAL |
|
Can you also push a quick fix for #96880 (comment) along the way? |
EgorBo
approved these changes
Jan 29, 2024
|
jkotas
reviewed
Jan 30, 2024
jakobbotsch
approved these changes
Jan 30, 2024
Diff results for #97677Throughput diffsThroughput diffs for linux/arm64 ran on windows/x64MinOpts (-0.00% to +0.01%)
Throughput diffs for osx/arm64 ran on windows/x64MinOpts (-0.01% to +0.00%)
Details here |
|
Going to merge this to fix diffs and to get a new SPMI collection going. The failure is #97688 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an issue introduced by #97535. AOT hosts don't support all the possible write barriers and blow things up if the JIT asks for ones they don't support.