Skip to content

[release/8.0] Adjust System.Net metrics for OTel conformance and consistency #93414

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
carlossanlop merged 5 commits into from
Oct 13, 2023
Merged

[release/8.0] Adjust System.Net metrics for OTel conformance and consistency #93414

carlossanlop merged 5 commits into from
Oct 13, 2023

Conversation

@antonfirsov
Copy link
Contributor

@antonfirsov antonfirsov commented Oct 12, 2023 •
edited
Loading

Fixes #92956, fixes #92917, fixes #92837, fixes #93302

Backport of PRs #93255, #93254, #93322

Customer Impact

OpenTelemetry metrics is a new feature in .NET 8.0.
There are minor semantic aspects which are either not conforming to the OpenTelemetry standard (#92956, #92917), inconsistent with ASP.NET (#93302) or highly undesirable (#92837). Fixing these problems in .NET 9.0 would be a breaking change against 8.0, while implementing them in 8.0 GA has a much lower negative impact on customers.

Testing

Target test cases were added.

Risk

Low. It is new feature in 8.0, therefore only early adopters of the new feature may be broken - we expect they will prefer conformance to standard.

@ghost ghost added the area-System.Net.Http label Oct 12, 2023
@ghost ghost assigned antonfirsov Oct 12, 2023
@ghost
Copy link

ghost commented Oct 12, 2023

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

Issue Details

Adjust System.Net metrics for OTel conformance and consistency

Fixes #92956, fixes #92917, fixes #92837, fixes #93302

Backport of PRs #93255, #93254, #93322

Customer Impact

OpenTelemetry metrics is a new feature in .NET 8.0.
There are minor semantic aspects which are either not conforming to the OpenTelemetry standard (#92956, #92917), inconsistent with ASP.NET (#93302) or highly undesirable (#92837). Fixing these problems in .NET 9.0 would be a breaking change against 8.0, while implementing them in 8.0 GA has a much lower negative impact on customers.

Testing

Target test cases were added.

Risk

Low. It is new feature in 8.0, therefore only early adopters of the new feature may be broken - we expect they will prefer conformance to standard.

Author: antonfirsov
Assignees: -
Labels:

area-System.Net.Http
Milestone: -

@antonfirsov antonfirsov added this to the 8.0.0 milestone Oct 12, 2023
@antonfirsov antonfirsov added the Servicing-consider Issue for next servicing release review label Oct 12, 2023
@antonfirsov
Copy link
Contributor Author

antonfirsov commented Oct 12, 2023

/azp run runtime-libraries-coreclr outerloop

@azure-pipelines
Copy link

azure-pipelines bot commented Oct 12, 2023

Azure Pipelines successfully started running 1 pipeline(s).

@antonfirsov antonfirsov requested a review from JamesNK October 12, 2023 20:18
@ghost
Copy link

ghost commented Oct 12, 2023

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

Issue Details

Fixes #92956, fixes #92917, fixes #92837, fixes #93302

Backport of PRs #93255, #93254, #93322

Customer Impact

OpenTelemetry metrics is a new feature in .NET 8.0.
There are minor semantic aspects which are either not conforming to the OpenTelemetry standard (#92956, #92917), inconsistent with ASP.NET (#93302) or highly undesirable (#92837). Fixing these problems in .NET 9.0 would be a breaking change against 8.0, while implementing them in 8.0 GA has a much lower negative impact on customers.

Testing

Target test cases were added.

Risk

Low. It is new feature in 8.0, therefore only early adopters of the new feature may be broken - we expect they will prefer conformance to standard.

Author: antonfirsov
Assignees: antonfirsov
Labels:

Servicing-consider, area-System.Net, area-System.Net.Http
Milestone: 8.0.0

@build-analysis build-analysis bot mentioned this pull request Oct 12, 2023
Closed
@antonfirsov antonfirsov mentioned this pull request Oct 12, 2023
Closed
@antonfirsov
Copy link
Contributor Author

antonfirsov commented Oct 13, 2023

/azp run runtime-libraries-coreclr outerloop

@azure-pipelines
Copy link

azure-pipelines bot commented Oct 13, 2023

Azure Pipelines successfully started running 1 pipeline(s).

@carlossanlop carlossanlop added Servicing-approved Approved for servicing release and removed Servicing-consider Issue for next servicing release review labels Oct 13, 2023
@carlossanlop
Copy link
Contributor

carlossanlop commented Oct 13, 2023

Approved by Tactics via email.

@carlossanlop
Copy link
Contributor

carlossanlop commented Oct 13, 2023

The CI failures are unrelated.

@carlossanlop carlossanlop merged commit 60b77a6 into dotnet:release/8.0 Oct 13, 2023
@antonfirsov antonfirsov mentioned this pull request Oct 16, 2023
Closed
This was referenced Oct 16, 2023
Closed
Closed
Closed
@ghost ghost locked as resolved and limited conversation to collaborators Nov 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@karelz karelz karelz approved these changes

@MihaZupan MihaZupan MihaZupan approved these changes

@noahfalk noahfalk Awaiting requested review from noahfalk

@JamesNK JamesNK Awaiting requested review from JamesNK

Assignees

@antonfirsov antonfirsov

Labels

area-System.Net Servicing-approved Approved for servicing release

Projects

None yet

Milestone

8.0.0

Development

Successfully merging this pull request may close these issues.

4 participants

@antonfirsov @carlossanlop @karelz @MihaZupan