Rename server.socket.address to network.peer.address
#93255
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging subscribers to this area: @dotnet/ncl Issue DetailsAddress #92956: Keep .NET metrics in sync with OTel by implementing a naming change from open-telemetry/semantic-conventions#342. An 8.0 backport is planned to avoid future breaking changes.
|
MihaZupan
approved these changes
Oct 9, 2023
src/libraries/System.Net.Http/tests/FunctionalTests/MetricsTest.cs
Outdated
Show resolved
Hide resolved
JamesNK
approved these changes
Oct 10, 2023
stephentoub
approved these changes
Oct 10, 2023
karelz
approved these changes
Oct 10, 2023
antonfirsov
added a commit
to antonfirsov/runtime
that referenced
this pull request
Oct 12, 2023
carlossanlop
pushed a commit
that referenced
this pull request
Oct 13, 2023
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Address #92956:
Keep .NET metrics in sync with OTel by implementing a naming change from open-telemetry/semantic-conventions#342. An 8.0 backport is planned to avoid future breaking changes.