-
Couldn't load subscription status.
- Fork 5.2k
Handle async continuation in TransitionFrame and ArgIterator
#117104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Tagging subscribers to this area: @mangod9 |
|
The reason for the GC stress failures on x86 is that GC stress does not protect continuation returns. Non-x86 platforms get that for free from the call site GC info, but for x86 GC stress needs to do an extra step, just like for protecting the ordinary returns. |
Some notes on this:
2 above made me suspect a bad codegen issue somewhere (storing |
Ah... I fixed this in the prototype. I guess the fix disappeared at some point. Thanks for looking. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks!
Co-authored-by: Jan Kotas <[email protected]>
|
/ba-g Infra issues |
ArgIteratorexpects)Fix #116322