Skip to content

Conversation

@ilonatommy
Copy link
Member

@ilonatommy ilonatommy commented Jul 19, 2024

Fixes #83497. New emscripten had the required change.

The reason for blocking changed, if we shorten the path, e.g. by changing s_unicodeChars = "\u9FC0\u8712\u679B\u906B\u486B\u7149" => "\u9FC0\u8712" and removing blz_aot_{config}_{GetRandomId()} from the project name (effectively, shortening the path to ...compiled_methods.txt), the test passes. The remaining issue is problem with long paths on Windows.

Now it fails with

C:\Users\user\source\repos\runtime-fork\artifacts\bin\Wasm.Build.Tests\Release\net9.0\win-x64\wbt artifacts\A├ÜÔöÉ├ç┼ö┼ą─║┼á├Ś┼Ą├Ü├╝┼║┼ä├ş┼║┼í┼»├ź\obj\Release\net9.0\wasm\for-publish\tokens\A_E9__BF__80__E8__9C__92__E6__9E__9B__E9__81__AB__E4__A1__AB__E7__85__89__dll_compiled_methods.txt

which is #103625.

@ilonatommy ilonatommy added arch-wasm WebAssembly architecture area-Build-mono labels Jul 19, 2024
@ilonatommy ilonatommy requested a review from radekdoulik July 19, 2024 13:11
@ilonatommy ilonatommy self-assigned this Jul 19, 2024
@ilonatommy ilonatommy requested a review from maraf as a code owner July 19, 2024 13:11
@ilonatommy
Copy link
Member Author

I merged to trigger WasmBuildTests on browser, Windows and it worked but now same lane on Linix does not run:

browser-wasm linux Release WasmBuildTests


Started: Today at 11:47 AM
Duration: 47m 11s

9 queue time variables used
Expanded: and(False, or(eq(variables['alwaysRunVar'], True), eq(variables['isDefaultPipeline'], variables['shouldRunWasmBuildTestsOnDefaultPipeline'])))
Result: False

closing and opening to see if it helps

@ilonatommy ilonatommy closed this Jul 22, 2024
@ilonatommy ilonatommy reopened this Jul 22, 2024
@ilonatommy
Copy link
Member Author

/azp run runtime-wasm

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@ilonatommy ilonatommy merged commit e15509b into dotnet:main Jul 22, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Aug 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

arch-wasm WebAssembly architecture area-Build-mono

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[browser][publish] Unicode in the path are not parsed correctly in Windows for AOT/relink by emcc

2 participants