Skip to content

Commit e15509b

Browse files
authored
[browser][publish] Unicode in the path are parsed correctly in Windows for AOT/relink by emcc (#105144)
* The reason for blocking changed. * Leaving information in case local run fails.
1 parent f1dd158 commit e15509b

File tree

2 files changed

+5
-11
lines changed

2 files changed

+5
-11
lines changed

src/mono/wasm/Wasm.Build.Tests/Blazor/BuildPublishTests.cs

Lines changed: 5 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -46,18 +46,13 @@ public static TheoryData<string, bool> TestDataForDefaultTemplate_WithWorkload(b
4646
{
4747
// AOT does not support managed debugging, is disabled by design
4848
data.Add("Debug", false);
49+
data.Add("Debug", true);
4950
}
50-
data.Add("Release", false); // Release relinks by default
5151

52-
// [ActiveIssue("https://github.com/dotnet/runtime/issues/83497", TestPlatforms.Windows)]
53-
if (!RuntimeInformation.IsOSPlatform(OSPlatform.Windows))
54-
{
55-
if (!isAot)
56-
{
57-
data.Add("Debug", true);
58-
}
59-
data.Add("Release", true);
60-
}
52+
// [ActiveIssue("https://github.com/dotnet/runtime/issues/103625", TestPlatforms.Windows)]
53+
// when running locally the path might be longer than 260 chars and these tests can fail with AOT
54+
data.Add("Release", false); // Release relinks by default
55+
data.Add("Release", true);
6156
return data;
6257
}
6358

src/mono/wasm/Wasm.Build.Tests/Blazor/MiscTests3.cs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,6 @@ public MiscTests3(ITestOutputHelper output, SharedBuildPerTestClassFixture build
2929
[InlineData("Release", /*build*/true, /*publish*/false)]
3030
[InlineData("Release", /*build*/false, /*publish*/true)]
3131
[InlineData("Release", /*build*/true, /*publish*/true)]
32-
[ActiveIssue("https://github.com/dotnet/runtime/issues/87877", TestPlatforms.Windows)]
3332
public async Task WithDllImportInMainAssembly(string config, bool build, bool publish)
3433
{
3534
// Based on https://github.com/dotnet/runtime/issues/59255

0 commit comments

Comments
 (0)