Skip to content

Conversation

@JanProvaznik
Copy link
Member

@JanProvaznik JanProvaznik commented Oct 17, 2024

Context

#10808 cleanup
update dependencies from Arcade
fix build errors

Changes Made

  1. update dependencies from Arcade - enabled propagating updates through Darc .NET 8 servicing

  2. remove BuildXL feed from nuget config - the feed has been deleted and the BuildXL packages are now taken from dotnet-tools feed.

  3. Suppress warning IDE0305 failing https://github.com/dotnet/msbuild/runs/31503006515

src/Shared/CopyOnWriteDictionary.cs#L387

src/Shared/CopyOnWriteDictionary.cs(387,56): error IDE0305: (NETCORE_ENGINEERING_TELEMETRY=Build) Collection initialization can be simplified (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/style-rules/ide0305)
  1. Suppress API compatibility errors failing https://github.com/dotnet/msbuild/runs/31553017667 , which appeared after taking the bugfixes to compat analyzer from arcade [vs17.8] update arcade and fix build  #10838 (comment)

  2. include PortableRuntimeIdentifierGraph.json whose absence fails here https://github.com/dotnet/msbuild/runs/31596126390

No functional/code changes.

Testing

Notes

dotnet-maestro bot and others added 6 commits October 17, 2024 13:06
…008.1

Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.XUnitExtensions
 From Version 8.0.0-beta.23425.2 -> To Version 8.0.0-beta.24508.1

Dependency coherency updates

Microsoft.DotNet.XliffTasks
 From Version 1.0.0-beta.23423.1 -> To Version 1.0.0-beta.23475.1 (parent: Microsoft.DotNet.Arcade.Sdk
Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.XUnitExtensions

 From Version 8.0.0-beta.24508.1 -> To Version 8.0.0-beta.24516.1
@dotnet-policy-service
Copy link
Contributor

Hello! I noticed that you're targeting one of our servicing branches. Please consider updating the version.

@JanProvaznik JanProvaznik changed the title [vs17.8] arcade update and fix build [vs17.8] update arcade and fix build Oct 17, 2024
Copy link
Member

@YuliiaKovalova YuliiaKovalova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rainersigwald can we send it to tactics as "tell mode"?

@JanKrivanek
Copy link
Member

Is it possible to list what fixes are we backporting here and why?

Security related fixes should definitely be backported. As for functional changes and even fixes - this might need some discussion.

@JanProvaznik
Copy link
Member Author

Will revert 0932640 once Microsoft.BuildXL.Processes is in the new feed and then there will be no changes to the code, only the build and warning suppressions.

@JanProvaznik JanProvaznik merged commit e657d4d into dotnet:vs17.8 Oct 23, 2024
8 checks passed
ader1990 added a commit to ader1990/os that referenced this pull request Nov 4, 2024
Dotnet-8 tag 8.0.10 or older cannot be built anymore,
as Microsoft decided to retire the following repositories:

  * https://pkgs.dev.azure.com/ms/BuildXL/_packaging/BuildXL.Selfhost/nuget/v3/index.json
  * https://pkgs.dev.azure.com/ms/BuildXL/_packaging/BuildXL/nuget/v3/index.json

The repositories were replaced with:

  * https://pkgs.dev.azure.com/mseng/PipelineTools/_packaging/BuildXL.External.Dependencies/nuget/v3/index.json

The problem is that the tagged releases of dotnet <= 8.0.10 will never be able
to build anymore, as tags cannot be replaced.

The fix has landed to dotnet/msbuild#10838, and the
following tagged releases should be buildable again.

See: microsoft/BuildXL#1343

But, if we leverage the offline build, after the prep.sh has been run,
there is no required connection to the inexistent repositories, thus the build will
work for the old tags too.
xnox added a commit to wolfi-dev/os that referenced this pull request Nov 4, 2024
Dotnet-8 tag 8.0.10 or older cannot be built anymore, as Microsoft
decided to retire the following repositories:

*
https://pkgs.dev.azure.com/ms/BuildXL/_packaging/BuildXL.Selfhost/nuget/v3/index.json
*
https://pkgs.dev.azure.com/ms/BuildXL/_packaging/BuildXL/nuget/v3/index.json

The repositories were replaced with:

*
https://pkgs.dev.azure.com/mseng/PipelineTools/_packaging/BuildXL.External.Dependencies/nuget/v3/index.json

The problem is that the tagged releases of dotnet <= 8.0.10 will never
be able to build anymore, as tags cannot be replaced.

The fix has landed to dotnet/msbuild#10838, and
the following tagged releases should be buildable again.

See: microsoft/BuildXL#1343

But, if we leverage the offline build, after the prep.sh has been run,
there is no required connection to the inexistent repositories, thus the
build will work for the old tags too.

<!---
Provide a short summary in the Title above. Examples of good PR titles:
* "ruby-3.1: new package"
* "haproxy: fix CVE-2014-123456"
-->

<!--
Please include references to any related issues or delete this section
otherwise.
 -->

Fixes:

Related:

### Pre-review Checklist

<!--
This checklist is mostly useful as a reminder of small things that can
easily be
forgotten – it is meant as a helpful tool rather than hoops to jump
through.

At the moment of this PR you have the most information on what all the
change
will affect, so please take the time to jot it down.

Put an `x` in all the items that apply, make notes next to any that
haven't been
addressed, and remove any items that are not relevant to this PR.

-->

#### For new package PRs only
<!-- remove if unrelated -->
- [ ] This PR is marked as fixing a pre-existing package request bug
- [ ] Alternatively, the PR is marked as related to a pre-existing
package request bug, such as a dependency
- [ ] REQUIRED - The package is available under an OSI-approved or
FSF-approved license
- [ ] REQUIRED - The version of the package is still receiving security
updates
- [ ] This PR links to the upstream project's support policy (e.g.
`endoflife.date`)

#### For new version streams
<!-- remove if unrelated -->
- [ ] The upstream project actually supports multiple concurrent
versions.
- [ ] Any subpackages include the version string in their package name
(e.g. `name: ${{package.name}}-compat`)
- [ ] The package (and subpackages) `provides:` logical unversioned
forms of the package (e.g. `nodejs`, `nodejs-lts`)
- [ ] If non-streamed package names no longer built, open PR to withdraw
them (see [WITHDRAWING
PACKAGES](https://github.com/wolfi-dev/os/blob/main/WITHDRAWING_PACKAGES.md))

#### For package updates (renames) in the base images
<!-- remove if unrelated -->
When updating packages part of base images (i.e.
cgr.dev/chainguard/wolfi-base or ghcr.io/wolfi-dev/sdk)
- [ ] REQUIRED cgr.dev/chainguard/wolfi-base and ghcr.io/wolfi-dev/sdk
images successfully build
- [ ] REQUIRED cgr.dev/chainguard/wolfi-base and ghcr.io/wolfi-dev/sdk
contain no obsolete (no longer built) packages
- [ ] Upon launch, does `apk upgrade --latest` successfully upgrades
packages or performs no actions

#### For security-related PRs
<!-- remove if unrelated -->
- [ ] The security fix is recorded in the
[advisories](https://github.com/wolfi-dev/advisories) repo

#### For version bump PRs
<!-- remove if unrelated -->
- [ ] The `epoch` field is reset to 0

#### For PRs that add patches
<!-- remove if unrelated -->
- [ ] Patch source is documented

---------

Co-authored-by: Dimitri John Ledkov <[email protected]>
This was referenced Oct 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants