Skip to content

Commit 713249a

Browse files
ader1990xnox
andauthored
dotnet-8: use offline build (#33140)
Dotnet-8 tag 8.0.10 or older cannot be built anymore, as Microsoft decided to retire the following repositories: * https://pkgs.dev.azure.com/ms/BuildXL/_packaging/BuildXL.Selfhost/nuget/v3/index.json * https://pkgs.dev.azure.com/ms/BuildXL/_packaging/BuildXL/nuget/v3/index.json The repositories were replaced with: * https://pkgs.dev.azure.com/mseng/PipelineTools/_packaging/BuildXL.External.Dependencies/nuget/v3/index.json The problem is that the tagged releases of dotnet <= 8.0.10 will never be able to build anymore, as tags cannot be replaced. The fix has landed to dotnet/msbuild#10838, and the following tagged releases should be buildable again. See: microsoft/BuildXL#1343 But, if we leverage the offline build, after the prep.sh has been run, there is no required connection to the inexistent repositories, thus the build will work for the old tags too. <!--- Provide a short summary in the Title above. Examples of good PR titles: * "ruby-3.1: new package" * "haproxy: fix CVE-2014-123456" --> <!-- Please include references to any related issues or delete this section otherwise. --> Fixes: Related: ### Pre-review Checklist <!-- This checklist is mostly useful as a reminder of small things that can easily be forgotten – it is meant as a helpful tool rather than hoops to jump through. At the moment of this PR you have the most information on what all the change will affect, so please take the time to jot it down. Put an `x` in all the items that apply, make notes next to any that haven't been addressed, and remove any items that are not relevant to this PR. --> #### For new package PRs only <!-- remove if unrelated --> - [ ] This PR is marked as fixing a pre-existing package request bug - [ ] Alternatively, the PR is marked as related to a pre-existing package request bug, such as a dependency - [ ] REQUIRED - The package is available under an OSI-approved or FSF-approved license - [ ] REQUIRED - The version of the package is still receiving security updates - [ ] This PR links to the upstream project's support policy (e.g. `endoflife.date`) #### For new version streams <!-- remove if unrelated --> - [ ] The upstream project actually supports multiple concurrent versions. - [ ] Any subpackages include the version string in their package name (e.g. `name: ${{package.name}}-compat`) - [ ] The package (and subpackages) `provides:` logical unversioned forms of the package (e.g. `nodejs`, `nodejs-lts`) - [ ] If non-streamed package names no longer built, open PR to withdraw them (see [WITHDRAWING PACKAGES](https://github.com/wolfi-dev/os/blob/main/WITHDRAWING_PACKAGES.md)) #### For package updates (renames) in the base images <!-- remove if unrelated --> When updating packages part of base images (i.e. cgr.dev/chainguard/wolfi-base or ghcr.io/wolfi-dev/sdk) - [ ] REQUIRED cgr.dev/chainguard/wolfi-base and ghcr.io/wolfi-dev/sdk images successfully build - [ ] REQUIRED cgr.dev/chainguard/wolfi-base and ghcr.io/wolfi-dev/sdk contain no obsolete (no longer built) packages - [ ] Upon launch, does `apk upgrade --latest` successfully upgrades packages or performs no actions #### For security-related PRs <!-- remove if unrelated --> - [ ] The security fix is recorded in the [advisories](https://github.com/wolfi-dev/advisories) repo #### For version bump PRs <!-- remove if unrelated --> - [ ] The `epoch` field is reset to 0 #### For PRs that add patches <!-- remove if unrelated --> - [ ] Patch source is documented --------- Co-authored-by: Dimitri John Ledkov <[email protected]>
1 parent d024785 commit 713249a

File tree

1 file changed

+4
-3
lines changed

1 file changed

+4
-3
lines changed

dotnet-8.yaml

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
package:
22
name: dotnet-8
33
version: 8.0.10
4-
epoch: 0
4+
epoch: 1
55
description: ".NET SDK"
66
copyright:
77
- license: MIT
@@ -55,12 +55,13 @@ pipeline:
5555
./prep.sh --bootstrap
5656
# /p:PrebuiltPackagesPath=/home/build/src/packages \
5757
- runs: |
58-
./build.sh --online --clean-while-building \
58+
./build.sh --clean-while-building \
5959
-- \
6060
/v:n \
6161
/p:ContinueOnPrebuiltBaselineError=true \
6262
/p:MinimalConsoleLogOutput=false \
63-
/p:SkipPortableRuntimeBuild=true
63+
/p:SkipPortableRuntimeBuild=true \
64+
/p:BuildWithOnlineSources=false
6465
- runs: |
6566
mkdir -p "${{targets.destdir}}"/usr/share/dotnet
6667
mkdir -p "${{targets.destdir}}"/usr/bin

0 commit comments

Comments
 (0)