Skip to content

React to #7751 #7842

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 23, 2019
Merged

React to #7751 #7842

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 0 additions & 14 deletions src/SignalR/samples/SignalRSamples/Startup.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@
using System;
using System.IO;
using System.Reflection;
using System.Threading;
using System.Threading.Tasks;
using Microsoft.AspNetCore.Builder;
using Microsoft.AspNetCore.Hosting;
Expand Down Expand Up @@ -32,17 +31,6 @@ public void ConfigureServices(IServiceCollection services)
})
.AddMessagePackProtocol();
//.AddStackExchangeRedis();

services.AddCors(o =>
{
o.AddPolicy("Everything", p =>
{
p.AllowAnyHeader()
.AllowAnyMethod()
.AllowAnyOrigin()
.AllowCredentials();
});
});
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know what was using this before, but now this causes the app to crash on startup, so removing it is at least better.

If we can find out how CORS is supposed to be used in the SignalRSamples app, we can redo the CORS configuration in a way that's still allowed.

}

// This method gets called by the runtime. Use this method to configure the HTTP request pipeline.
Expand All @@ -55,8 +43,6 @@ public void Configure(IApplicationBuilder app, IWebHostEnvironment env)
app.UseDeveloperExceptionPage();
}

app.UseCors("Everything");

app.UseRouting(routes =>
{
routes.MapHub<DynamicChat>("/dynamic");
Expand Down