React to #7751 #7842
Merged
React to #7751 #7842
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
halter73
commented
Feb 22, 2019
| .AllowAnyOrigin() | ||
| .AllowCredentials(); | ||
| }); | ||
| }); |
There was a problem hiding this comment.
I don't know what was using this before, but now this causes the app to crash on startup, so removing it is at least better.
If we can find out how CORS is supposed to be used in the SignalRSamples app, we can redo the CORS configuration in a way that's still allowed.
|
Need to remove the |
halter73
force-pushed
the
halter73/7841
branch
from
e58a918 to
e90906e
Compare
|
@BrennanConroy Good catch. Now approve it 😄 |
BrennanConroy
approved these changes
Feb 22, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #7841 for why we need to react to #7751