Skip to content

Harden SignatureEquals nullability checks #53052

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Harden SignatureEquals nullability checks #53052

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion src/Http/Http.Extensions/gen/StaticRouteHandlerModel/Endpoint.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,8 +108,13 @@ public override int GetHashCode() =>

public static bool SignatureEquals(Endpoint a, Endpoint b)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should the parameters be nullable?

Suggested change
public static bool SignatureEquals(Endpoint a, Endpoint b)
public static bool SignatureEquals(Endpoint? a, Endpoint? b)

{
if (a == null || b == null)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Handle both being null?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could do so by returning ReferenceEquals(a, b)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
if (a == null || b == null)
if (a == null && b == null)
{
return true;
}
if (a == null || b == null)

{
return false;
}

if (!string.Equals(a.Response?.WrappedResponseType, b.Response?.WrappedResponseType, StringComparison.Ordinal) ||
!a.HttpMethod.Equals(b.HttpMethod, StringComparison.Ordinal) ||
!string.Equals(a.HttpMethod, b.HttpMethod, StringComparison.Ordinal) ||
a.Parameters.Length != b.Parameters.Length)
{
return false;
Expand Down