Harden SignatureEquals nullability checks #53052
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
captainsafia
requested review from
BrennanConroy and
halter73
as code owners
ghost
added
the
area-networking
JamesNK
reviewed
Dec 29, 2023
| @@ -108,8 +108,13 @@ public Endpoint(IInvocationOperation operation, WellKnownTypes wellKnownTypes, S | |||
|
|
|||
| public static bool SignatureEquals(Endpoint a, Endpoint b) | |||
There was a problem hiding this comment.
Should the parameters be nullable?
Suggested change
| public static bool SignatureEquals(Endpoint a, Endpoint b) | |
| public static bool SignatureEquals(Endpoint? a, Endpoint? b) |
JamesNK
reviewed
Dec 29, 2023
| @@ -108,8 +108,13 @@ public Endpoint(IInvocationOperation operation, WellKnownTypes wellKnownTypes, S | |||
|
|
|||
| public static bool SignatureEquals(Endpoint a, Endpoint b) | |||
| { | |||
| if (a == null || b == null) | |||
There was a problem hiding this comment.
Could do so by returning ReferenceEquals(a, b)
JamesNK
reviewed
Dec 29, 2023
| @@ -108,8 +108,13 @@ public Endpoint(IInvocationOperation operation, WellKnownTypes wellKnownTypes, S | |||
|
|
|||
| public static bool SignatureEquals(Endpoint a, Endpoint b) | |||
| { | |||
| if (a == null || b == null) | |||
There was a problem hiding this comment.
Suggested change
| if (a == null || b == null) | |
| if (a == null && b == null) | |
| { | |
| return true; | |
| } | |
| if (a == null || b == null) |
|
Unit tests? |
ghost
added
the
pending-ci-rerun
wtgodbe
removed
the
pending-ci-rerun
dotnet-policy-service
bot
added
the
area-infrastructure
wtgodbe
removed
the
area-infrastructure
dotnet-policy-service
bot
added
the
pending-ci-rerun
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #52492