Replace ISystemClock with TimeProvider in OutputCaching, ResponseCaching #47753
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
7 tasks
Tratcher
force-pushed
the
tratcher/internalclocks
branch
from
0c0d777 to
d55d2a3
Compare
Tratcher
changed the title
src/Middleware/OutputCaching/test/OutputCacheMiddlewareTests.cs
Outdated
Show resolved
Hide resolved
Tratcher
added
area-runtime
and removed
area-signalr
sebastienros
approved these changes
Apr 19, 2023
amcasey
added
area-middleware
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replacing the internal clock abstractions with the new official abstraction.
Description
Each of these components had their own ISystemClock abstraction and implementation for test purposes. They were all internal, so we can remove them without breaking changes.
Contributes to #47472