Skip to content

Onboard aspnetcore into the new TimeProvider type from runtime #47472

Closed
@joperezr

Description

@joperezr

Now that TimeProvider has been added to the platform in dotnet/runtime#83604, we should make the following changes in the aspnetcore layer for .NET 8:

  • Remove all the copies of ISystemClock that exist in the repo (there are at least 6, with types that implement them), particularly all the ones that are not publicly exposed, and replace the places where they are used with TimeProvider.
  • Two of these copies of ISystemClock are actually public and part of some of our API surface: Microsoft.AspNetCore.Authentication.ISystemClock, and Microsoft.AspNetCore.Server.kestrel.Core.Internal.Infrastructure.ISystemClock. We should consider deprecating those as well as the affected API that exposes them, and consider if there are new APIs/overloads that should be exposed that use TimeProvider as opposed to ISystemClock.

cc: @tarekgh @Tratcher @adityamandaleeka @davidfowl @mkArtakMSFT

Metadata

Metadata

Assignees

Labels

api-approvedAPI was approved in API review, it can be implementedarea-networkingIncludes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions

Type

No type

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions