Skip to content

Move SegmentWriteStream to shared resource #47180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 21, 2023
Merged

Move SegmentWriteStream to shared resource #47180

merged 1 commit into from
Mar 21, 2023

Conversation

Skaanning
Copy link
Contributor

@Skaanning Skaanning commented Mar 13, 2023 •
edited
Loading

Move SegmentWriteStream to shared resource

Description

Moved SegmentWriteStream.cs from the projects ResponseCaching and OutputCaching to the shared folder.

Moved SegmentWriteStream namespace from Microsoft.AspNetCore.ResponseCaching and Microsoft.AspNetCore.OutputCaching to Microsoft.AspNetCore.WriteStream

Fixes #45957

@ghost ghost added area-runtime community-contribution Indicates that the PR has been added by a community member labels Mar 13, 2023
@ghost
Copy link

ghost commented Mar 13, 2023

Thanks for your PR, @Skaanning. Someone from the team will get assigned to your PR shortly and we'll get it reviewed.

@adityamandaleeka
Copy link
Member

Thanks @Skaanning!

@adityamandaleeka
Copy link
Member

This looks good to me. Will do a sanity check to make sure the moved tests are still running.

cc: @sebastienros

@adityamandaleeka adityamandaleeka self-assigned this Mar 13, 2023
@ghost
Copy link

ghost commented Mar 21, 2023

Looks like this PR hasn't been active for some time and the codebase could have been changed in the meantime.
To make sure no breaking changes are introduced, please leave an /azp run comment here to rerun the CI pipeline and confirm success before merging the change.

@ghost ghost added the pending-ci-rerun When assigned to a PR indicates that the CI checks should be rerun label Mar 21, 2023
@adityamandaleeka adityamandaleeka removed the pending-ci-rerun When assigned to a PR indicates that the CI checks should be rerun label Mar 21, 2023
@adityamandaleeka
Copy link
Member

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@Skaanning
Copy link
Contributor Author

Hi, sorry I don't quite know how the process works here.
Am I supposed to do something?

@sebastienros sebastienros merged commit 605fb06 into dotnet:main Mar 21, 2023
@ghost ghost added this to the 8.0-preview4 milestone Mar 21, 2023
@sebastienros
Copy link
Member

@Skaanning I didn't realize the PR was done by an external contributor, and hence you couldn't merge it once I approved it.

@adityamandaleeka
Copy link
Member

Thanks @Skaanning!

@amcasey amcasey added area-middleware Includes: URL rewrite, redirect, response cache/compression, session, and other general middlewares and removed area-runtime labels Jun 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adityamandaleeka adityamandaleeka adityamandaleeka approved these changes

@sebastienros sebastienros sebastienros approved these changes

@Tratcher Tratcher Awaiting requested review from Tratcher

@BrennanConroy BrennanConroy Awaiting requested review from BrennanConroy BrennanConroy is a code owner

Assignees

@adityamandaleeka adityamandaleeka

Labels
area-middleware Includes: URL rewrite, redirect, response cache/compression, session, and other general middlewares community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Milestone
8.0-preview4
Development

Successfully merging this pull request may close these issues.

Duplicate SegmentWriteStream
4 participants
@Skaanning @adityamandaleeka @sebastienros @amcasey