Duplicate SegmentWriteStream

[JamesNK]

Is there an existing issue for this?

• I have searched the existing issues

Describe the bug

Copies exist in:

• OutputCaching - https://github.com/dotnet/aspnetcore/blob/cefc6ccf4b23ac9f07418cd10e374cf533276eee/src/Middleware/OutputCaching/src/Streams/SegmentWriteStream.cs
• ResponseCaching - https://github.com/dotnet/aspnetcore/blob/cefc6ccf4b23ac9f07418cd10e374cf533276eee/src/Middleware/ResponseCaching/src/Streams/SegmentWriteStream.cs

Expected Behavior

One copy, in shared source.

Steps To Reproduce

No response

Exceptions (if any)

No response

.NET Version

No response

Anything else?

No response

[JamesNK]

Good external contribution and first issue.

Should wait until after #45954 is done to avoid conflicts.

[JamesNK]

Also, check if there is anything else that can be shared between the two projects.

Thanks for contacting us.

We're moving this issue to the .NET 8 Planning milestone for future evaluation / consideration. We would like to keep this around to collect more feedback, which can help us with prioritizing this work. We will re-evaluate this issue, during our next planning meeting(s).
If we later determine, that the issue has no community involvement, or it's very rare and low-impact issue, we will close it - so that the team can focus on more important and high impact issues.
To learn more about what to expect next and how this issue will be handled you can read more about our triage process here.

[Hellevar]

Hi, @JamesNK !
I'd like to grab this work, but I'm wondering - how to properly de-duplicate such things? If I put into Shared folder and reference the same way as it's done for TaskToApm helper file - there still will be duplicated tests.
Is it expected that new 'shared' project will be created just for these two projects?

[JamesNK]

By shared, I mean share the source, and then add the source to both projects. You can see a lot of examples of doing that throughout aspnetcore source code. e.g.

aspnetcore/src/DataProtection/DataProtection/src/Microsoft.AspNetCore.DataProtection.csproj

Line 23 in 97a118c

<Compile Include="$(SharedSourceRoot)ThrowHelpers\ArgumentNullThrowHelper.cs" LinkBase="Shared" />

There is a project for shared tests at https://github.com/dotnet/aspnetcore/tree/main/src/Shared/test/Shared.Tests