Skip to content

Adjust shared framework and targeting pack tests to check _all_ assembly versions #43359

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 18, 2022
Merged

Adjust shared framework and targeting pack tests to check _all_ assembly versions #43359

merged 1 commit into from
Aug 18, 2022

Conversation

dougbu
Copy link
Contributor

@dougbu dougbu commented Aug 18, 2022

@dougbu
Adjust shared framework and targeting pack tests to check _all_ assem…
8ea329a 
…bly versions

- check against potentially-different versions for dotnet/aspnetcore and dotnet/runtime assemblies
- backport parts of 416b981
  - was "Update branding to 8.0.0-alpha1 (#43307)"
@dougbu dougbu requested review from halter73 and a team August 18, 2022 02:01
@dougbu dougbu requested a review from Pilchie as a code owner August 18, 2022 02:01
@ghost ghost added the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label Aug 18, 2022
@dougbu
Copy link
Contributor Author

dougbu commented Aug 18, 2022

Aside from minimizing merge conflicts, this PR expands the assemblies checked in a couple of our App.UnitTests tests and avoids some updates the next time we do major / minor rebranding.

@dougbu
Copy link
Contributor Author

dougbu commented Aug 18, 2022

@wtgodbe at this point, we don't need to worry about tell-mode labeling in this branch, do we❔

@wtgodbe
Copy link
Member

wtgodbe commented Aug 18, 2022

@wtgodbe at this point, we don't need to worry about tell-mode labeling in this branch, do we❔

I'm not sure, but my guess would be yes since it's for rc2. I'll see if I can get a bar check in tactics today

@dougbu
Copy link
Contributor Author

dougbu commented Aug 18, 2022

I'll see if I can get a bar check in tactics today

To be clear, the bar isn't really the issue because this is (and #43357 was) a test-only change. The bar's interesting of course but I was just wondering whether we needed to label PRs that pass pretty much any bar.

@dougbu dougbu enabled auto-merge (squash) August 18, 2022 16:30
@wtgodbe wtgodbe disabled auto-merge August 18, 2022 16:34
@wtgodbe wtgodbe enabled auto-merge (squash) August 18, 2022 16:38
@wtgodbe
Copy link
Member

wtgodbe commented Aug 18, 2022

Whoops, didn't mean to disable auto-merge

@wtgodbe
Copy link
Member

wtgodbe commented Aug 18, 2022

RC2 isn't in ask mode yet, so no need for tell-mode label here.

@wtgodbe wtgodbe merged commit 14a3e98 into dotnet:release/7.0 Aug 18, 2022
@dougbu dougbu deleted the dougbu/backport.416b981cc484f1ecc5e0ab78692c3498001d7290 branch August 18, 2022 23:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wtgodbe wtgodbe wtgodbe approved these changes

@halter73 halter73 Awaiting requested review from halter73

@Pilchie Pilchie Awaiting requested review from Pilchie

Assignees
No one assigned
Labels
area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dougbu @wtgodbe