Skip to content

Conversation

dougbu
Copy link
Contributor

@dougbu dougbu commented Aug 15, 2022

No description provided.

@dougbu dougbu requested review from a team, wtgodbe and Pilchie as code owners August 15, 2022 19:32
Copy link
Member

@wtgodbe wtgodbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to update

ReferenceAssemblies = ReferenceAssemblies.Net.Net70.AddAssemblies(ImmutableArray.Create(
?

@dougbu
Copy link
Contributor Author

dougbu commented Aug 15, 2022

Do we need to update …

Shouldn't need to do that yet. Not changing any TFMs.

@wtgodbe
Copy link
Member

wtgodbe commented Aug 15, 2022

Shouldn't need to do that yet. Not changing any TFMs.

Looks like the doc needs updating: #43308

@halter73
Copy link
Member

Yeah. I think .NET 8 work should stay in feature branches for a while longer to avoid unnecessary merge conflicts.

@dougbu
Copy link
Contributor Author

dougbu commented Aug 16, 2022

Yeah. I think .NET 8 work should stay in feature branches for a while longer to avoid unnecessary merge conflicts.

What's the context for your comment @halter73❔ We're not changing TFMs at this point but are changing assembly and package versions, along w/ all other .NET repos.

@dougbu dougbu enabled auto-merge (squash) August 16, 2022 18:21
@dougbu dougbu added the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label Aug 16, 2022
@ghost
Copy link

ghost commented Aug 16, 2022

Hey @dotnet/aspnet-build, looks like this PR is something you want to take a look at.

@halter73
Copy link
Member

I just don't want any big changes in main to cause merge conflicts with the .NET 7 release branches which I expect will be the more active source of changes over the next few weeks.

If we agreed to start .NET 8 branding this early, fine I guess. That shouldn't cause hard to resolve conflicts by itself, but I don't see the benefit to starting this early. When do we release 8.0.0-alpha1?

I expect life would be a whole lot easier for most devs if main only tracked .NET 7 changes for a little longer.

@dougbu
Copy link
Contributor Author

dougbu commented Aug 16, 2022

Sorry, that's not the direction .NET has chosen at this time. We're rebranding now and in fact are late in doing so (due to test and infrastructure this hit yesterday).

@dougbu dougbu merged commit 416b981 into dotnet:main Aug 16, 2022
@dougbu dougbu deleted the dougbu/alpha1 branch August 16, 2022 20:12
@ghost ghost added this to the 8.0-alpha1 milestone Aug 16, 2022
wtgodbe pushed a commit that referenced this pull request Aug 18, 2022
…bly versions (#43359)

- check against potentially-different versions for dotnet/aspnetcore and dotnet/runtime assemblies
- backport parts of 416b981
  - was "Update branding to 8.0.0-alpha1 (#43307)"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants